[App Search] Convert Result Settings & Relevance Tuning pages to new page template #102845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ remove wrapper around empty state (auto handled by new page template) + update tests w/ new test helpers
- Remove old relevance_tuning_layout (which handled breadcrumbs, page header, flash messages, and callouts) in favor of simply using the new templtate + callouts (yay DRYing) - Remove panel wrapper around empty state (handled by new page template)
cee-chen
added
release_note:skip
JasonStoltz
reviewed
Jun 22, 2021
| expect(wrapper.find(EmptyState).dive().find(EuiEmptyPrompt).exists()).toBe(true); | ||
| expect(wrapper.find(Loading).exists()).toBe(false); | ||
| expect(wrapper.find(RelevanceTuningForm).exists()).toBe(false); | ||
| expect(subject().find(UnsavedChangesPrompt).prop('hasUnsavedChanges')).toBe(true); |
There was a problem hiding this comment.
UnsavedChangesPrompt could eventually go in the page template!
There was a problem hiding this comment.
Ooo!!! Nice idea, I love it!
JasonStoltz
approved these changes
Jun 22, 2021
JasonStoltz
approved these changes
Jun 22, 2021
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @JasonStoltz |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 22, 2021
…page template (elastic#102845) * Convert Result Settings page to new page template + remove wrapper around empty state (auto handled by new page template) + update tests w/ new test helpers * Convert Relevance Tuning page to new page template - Remove old relevance_tuning_layout (which handled breadcrumbs, page header, flash messages, and callouts) in favor of simply using the new templtate + callouts (yay DRYing) - Remove panel wrapper around empty state (handled by new page template) * Update router * [Polish] Spacing & icon polish from Davey see https://github.com/elastic/kibana/pull/101958/files
kibanamachine
added a commit
that referenced
this pull request
Jun 22, 2021
…page template (#102845) (#103018) * Convert Result Settings page to new page template + remove wrapper around empty state (auto handled by new page template) + update tests w/ new test helpers * Convert Relevance Tuning page to new page template - Remove old relevance_tuning_layout (which handled breadcrumbs, page header, flash messages, and callouts) in favor of simply using the new templtate + callouts (yay DRYing) - Remove panel wrapper around empty state (handled by new page template) * Update router * [Polish] Spacing & icon polish from Davey see https://github.com/elastic/kibana/pull/101958/files Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #102170 - converts more App Search pages to the new KibanaPageTemplate. I'm attempting to break up the AS layout conversion into smaller, easier to review chunks.
This PR handles the Result Settings & Relevance Tuning pages (+ bonus UI polish from Davey). As always, follow along by commit (and turn off whitespace diffs)
Screencaps
Checklist