Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App search cleanup #101958

Closed
wants to merge 8 commits into from
Closed

App search cleanup #101958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
76d416a
Update create new curation button
daveyholler Jun 10, 2021
45b46fd
Updates hidden doc message in Curations
daveyholler Jun 10, 2021
1ba29c0
Visually aligns search boxes on relevance tuning page
daveyholler Jun 10, 2021
5cba4b5
Adds an icon to the relevance tuning preview empty prompt
daveyholler Jun 10, 2021
570cafa
Updates schema page buttons
daveyholler Jun 10, 2021
cbc3706
More descriptive outbound links on Search UI page
daveyholler Jun 10, 2021
9807bf2
Adds a page description to the synonyms page
daveyholler Jun 10, 2021
154a03a
Places non-deletable field message in a callout
daveyholler Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lugins/enterprise_search/public/applications/app_search/components/curations/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const CURATIONS_OVERVIEW_TITLE = i18n.translate(
);
export const CREATE_NEW_CURATION_TITLE = i18n.translate(
'xpack.enterpriseSearch.appSearch.engine.curations.create.title',
{ defaultMessage: 'Create new curation' }
{ defaultMessage: 'Create a new curation' }
);
export const MANAGE_CURATION_TITLE = i18n.translate(
'xpack.enterpriseSearch.appSearch.engine.curations.manage.title',
Expand Down
2 changes: 1 addition & 1 deletion ...blic/applications/app_search/components/curations/curation/documents/hidden_documents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const HiddenDocuments: React.FC = () => {
<h3>
{i18n.translate(
'xpack.enterpriseSearch.appSearch.engine.curations.hiddenDocuments.emptyTitle',
{ defaultMessage: 'No documents are being hidden for this query' }
{ defaultMessage: "You haven't hidden any documents yet" }
)}
</h3>
}
Expand Down
2 changes: 1 addition & 1 deletion ...ns/app_search/components/relevance_tuning/relevance_tuning_form/relevance_tuning_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const RelevanceTuningForm: React.FC = () => {
return (
<section className="relevanceTuningForm">
<form>
<EuiSpacer size="s" />
<EuiSpacer size="m" />
<EuiTitle size="m">
<h2>
{i18n.translate(
Expand Down
1 change: 1 addition & 0 deletions ...h/public/applications/app_search/components/relevance_tuning/relevance_tuning_preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { RelevanceTuningLogic } from '.';
const emptyCallout = (
<EuiEmptyPrompt
data-test-subj="EmptyQueryPrompt"
iconType="glasses"
body={i18n.translate(
'xpack.enterpriseSearch.appSearch.engine.relevanceTuning.preview.enterQueryMessage',
{
Expand Down
3 changes: 2 additions & 1 deletion ...ugins/enterprise_search/public/applications/app_search/components/schema/views/schema.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,14 @@ export const Schema: React.FC = () => {
>
{i18n.translate(
'xpack.enterpriseSearch.appSearch.engine.schema.updateSchemaButtonLabel',
{ defaultMessage: 'Update types' }
{ defaultMessage: 'Save changes' }
)}
</EuiButton>,
<EuiButton
color="secondary"
disabled={isUpdating}
onClick={openModal}
iconType="plusInCircleFilled"
data-test-subj="addSchemaFieldModalButton"
>
{i18n.translate(
Expand Down
4 changes: 2 additions & 2 deletions ...ugins/enterprise_search/public/applications/app_search/components/search_ui/search_ui.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const SearchUI: React.FC = () => {
<EuiLink target="_blank" href="https://github.com/elastic/search-ui">
<FormattedMessage
id="xpack.enterpriseSearch.appSearch.engine.searchUI.repositoryLinkText"
defaultMessage="Learn more"
defaultMessage="View the Github repo"
/>
</EuiLink>
),
Expand All @@ -72,7 +72,7 @@ export const SearchUI: React.FC = () => {
<EuiLink target="_blank" href={`${DOCS_PREFIX}/reference-ui-guide.html`}>
<FormattedMessage
id="xpack.enterpriseSearch.appSearch.engine.searchUI.guideLinkText"
defaultMessage="Learn more"
defaultMessage="Learn more about Search UI"
/>
</EuiLink>
),
Expand Down
7 changes: 7 additions & 0 deletions ...plugins/enterprise_search/public/applications/app_search/components/synonyms/synonyms.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ export const Synonyms: React.FC = () => {
<SetPageChrome trail={getEngineBreadcrumbs([SYNONYMS_TITLE])} />
<EuiPageHeader
pageTitle={SYNONYMS_TITLE}
description={i18n.translate(
'xpack.enterpriseSearch.appSearch.engine.synonyms.description',
{
defaultMessage:
'Use synonyms to relate queries together that contextually have the same meaning in your dataset.',
}
)}
rightSideItems={[
<EuiButton fill onClick={() => openModal(null)}>
{i18n.translate(
Expand Down
10 changes: 8 additions & 2 deletions x-pack/plugins/enterprise_search/public/applications/shared/schema/add_field_modal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import React, { ChangeEvent, FormEvent, useEffect, useState } from 'react';
import {
EuiButton,
EuiButtonEmpty,
EuiCallOut,
EuiFieldText,
EuiFlexGroup,
EuiFlexItem,
Expand Down Expand Up @@ -83,8 +84,13 @@ export const SchemaAddFieldModal: React.FC<Props> = ({
<EuiModalHeaderTitle>{ADD_FIELD_MODAL_TITLE}</EuiModalHeaderTitle>
</EuiModalHeader>
<EuiModalBody>
<p>{ADD_FIELD_MODAL_DESCRIPTION}</p>
<EuiSpacer />
<EuiCallOut
color="warning"
size="s"
iconType="iInCircle"
title={<p>{ADD_FIELD_MODAL_DESCRIPTION}</p>}
/>
<EuiSpacer size="m" />
<EuiForm component="form" id={FORM_ID} onSubmit={submitForm}>
<EuiFlexGroup gutterSize="m">
<EuiFlexItem>
Expand Down