Opening Spy Panel on Area Chart disables chart Save button

[LeeDr]

Found in 4.4.0 on Chrome.

1. New Visualization
2. Area Chart
3. from new or saved search
4. Set Bucket, X-Axis, Date Histogram, @timestamp, Auto
5. Apply (if no results change timepicker to get results) - Save button is enabled :-)
6. click up arrow under chart to open spy panel - Save button is disabled :-(
7. close spy panel - Save button is still disabled :-(

(same for Pie Chart, I didn't test them all)

[epixa]

We need to confirm whether this is new to 4.4.0 or not. For now, I'm going to put the 4.4.0 label on it so we don't forget.

[LeeDr]

It's the same in 4.3.1.

[wwsean08]

So with some testing I found that this is caused because when you open the spy panel it marks the vis's state as dirty, whenever that happens the save button is disabled. You can see that when you do this the apply button becomes active again. If you click the apply button it "cleans" the state and you are able to save. That should at least give a workaround for now. I also noticed that after hitting the apply button subsequent openings and closings of the spy panel did not affect the ability to save the visualization.

Here's a recording of what I mean. (for some reason the software didn't show the normal cursor so you can't see the no symbol or whatever you wana call it)

[epixa]

Thanks for the details, @wwsean08. That'll help get this thing fixed up quicker.

[stormpython]

Thanks @wwsean08 for the head start.

So the issue here seems to occur at lines 128-133. The state is set to dirty because a vis spy parameter, spyPerPage is added to the editable vis state, but not the actual vis state.

And it seems that upon further inspection, the function transferVisState does not get run when the spy is opened. So while the spy adds a parameter to the editable vis state, there is no transfer of state to the actual vis state.