Skip to content

Commit

Permalink
Closes elastic#5860. Adding spyPerPage param to .spy.params instead o…
Browse files Browse the repository at this point in the history
…f on the editableVis.params.
  • Loading branch information
stormpython committed Jan 19, 2016
1 parent f0f639e commit 5209fa4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/plugins/spyModes/public/tableSpyMode.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<kbn-agg-table
table="table"
export-title="vis.title"
per-page="editableVis.params.spyPerPage">
per-page="spy.params.spyPerPage">
</kbn-agg-table>
4 changes: 2 additions & 2 deletions src/plugins/spyModes/public/tableSpyMode.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ define(function (require) {
if (!$scope.vis || !$scope.esResp) {
$scope.table = null;
} else {
if (!$scope.editableVis.params.spyPerPage) {
$scope.editableVis.params.spyPerPage = PER_PAGE_DEFAULT;
if (!$scope.spy.params.spyPerPage) {
$scope.spy.params.spyPerPage = PER_PAGE_DEFAULT;
}

$scope.table = tabifyAggResponse($scope.vis, $scope.esResp, {
Expand Down
1 change: 1 addition & 0 deletions src/ui/public/visualize/spy.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ define(function (require) {
var $container = $el.find('.visualize-spy-container');
var fullPageSpy = _.get($scope.spy, 'mode.fill', false);
$scope.modes = spyModes;
$scope.spy.params = $scope.spy.params || {};

function getSpyObject(name) {
name = _.isUndefined(name) ? $scope.spy.mode.name : name;
Expand Down

0 comments on commit 5209fa4

Please sign in to comment.