Fix for save button disabled when opening spy panel

[stormpython]

Closes #5860.

This fix will need to be backported.

Issue:

When opening the spy panel in the Visualize tab, after creating a visualization, the save button is disabled. This occurs because the initial opening of the spy panel renders the vis state as dirty. The underlying problem is that the parameter spyPerPage for the spy panel gets added to the editableVis state, but is not transferred to the actual vis state. And since there is a check here that determines whether the editableVis state and the actual vis state are equal, it returns false therefore rendering the vis state as dirty, causing the save button to be disabled.

For a more detailed explanation, see #5860.

Proposed solution:

The parameter spyPerPage should not be placed as a vis parameter since it is apart of the spy panel. The spyPerPage parameter is moved to the $scope.spy.params object from the $scope.vis.params object.

It seems that the spyPerPage parameter is not actually saved in the state across visualizations or within the same visualization. What I mean by that is, if I change the spyPerPage parameter in the UI to 25 and then close the spy panel; when I open it back up, the spyPerPage parameter is reset to 10.

This behavior doesn't change with this pull request and allows me to move the parameter to the $scope.spy object without having to worry about state changes. However, I believe this should be thoroughly tested in the UI.

[w33ble]

Sorry for the delay on this one. This seems to fix the issue and doesn't break the uiState stuff. LGTM!

[elasticsearch-bot]

Joe Fleming merged this into the following branches!

Branch	Commits
master	9086f50
4.x	f1d2d9f
4.4	5cc3f4f