Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tie peg parser generation into the dev server optimization #17284

Closed
Bargs opened this issue Mar 20, 2018 · 13 comments · Fixed by #103530 or #111881
Closed

Tie peg parser generation into the dev server optimization #17284

Bargs opened this issue Mar 20, 2018 · 13 comments · Fixed by #103530 or #111881
Labels
chore Feature:Timelion Timelion app and visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.15.0 v8.0.0

Comments

@Bargs
Copy link
Contributor

Bargs commented Mar 20, 2018

The kuery grammar gets precompiled and committed to git now, which means in dev you need to run grunt peg or grunt watch:peg to see your changes to .peg files. It would be really nice if these files were watched and compiled as a part of the usual optimization process.
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:KQL KQL and removed :Discovery labels Sep 16, 2018
@timroes timroes removed the good first issue low hanging fruit label Mar 1, 2019
@timroes timroes added Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers
Copy link
Member

Whatever solution we use for this should probably be consistent in the expressions plugin too (which also uses peg)

@tylersmalley tylersmalley mentioned this issue Dec 8, 2020
Closed
8 tasks
@tylersmalley
Copy link
Contributor

@lukeelmers this is on my radar as I have opened #85341 to remove Grunt, which is used by kquery. Think we can move this to a package?

@lukeelmers
Copy link
Member

@tylersmalley Yeah this is potentially something we could extract to a package, along with a few other pieces of es_query that have been problematic for different reasons (like circular dependencies & a core -> data dependency we need to remove).

I will bring this up so we can have it on the app services roadmap. Do you have a target release in mind for removing grunt?

@jbudz
Copy link
Member

jbudz commented Dec 15, 2020

Hey @lukeelmers - we're targeting 7.12 for Grunt removal currently. I'm happy to help if there's any bandwidth issues.

@lukeelmers
Copy link
Member

Thanks for offering to help @jbudz, I'll defer to @ppisljar and @alexh97 on how/when to move forward.

@ppisljar
Copy link
Member

ppisljar commented Jan 4, 2021

we would definitely appreciate help with this as we haven't planned for this for 7.12..

@jbudz
Copy link
Member

jbudz commented Feb 16, 2021

Mini bump on this - we pushed this to 7.13. Any chance we can work with someone on this for the next release cycle?

@jbudz
Copy link
Member

jbudz commented Apr 2, 2021

I made an attempt at moving it over to kbn-interpreter at #95465. I ran into issues between the global pegjs version and the version grunt is using, resulting in quite a few changed snapshots.

@lukeelmers lukeelmers mentioned this issue Apr 21, 2021
Closed
@wylieconlon
Copy link
Contributor

I didn't know about this issue and just made an attempt at the same thing today, as part of #97914. I asked @mistic about using Bazel, because we are using Bazel to generate the Tinymath grammar now. Maybe we can use Bazel for all the other use of pegjs too.

@wylieconlon wylieconlon mentioned this issue Apr 22, 2021
Closed
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 2, 2021
@lizozom lizozom mentioned this issue Jul 13, 2021
Merged
9 tasks
@jbudz
Copy link
Member

jbudz commented Jul 21, 2021

I'm reopening this - there's still the timelion grammar hooked into the grunt task. Feel free to close if I'm misunderstanding.

@jbudz jbudz reopened this Jul 21, 2021
@lizozom
Copy link
Contributor

lizozom commented Jul 21, 2021

@jbudz the never ending issue 🤷🏻‍♀️

@lizozom lizozom added Feature:Timelion Timelion app and visualization and removed Team:AppServices labels Jul 21, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 21, 2021
@lizozom lizozom added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Feature:KQL KQL labels Jul 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 21, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jul 22, 2021
jbudz added a commit to jbudz/kibana that referenced this issue Sep 10, 2021
@jbudz
[timelion] Move grammar to package
0e622b5 
This moves the timelion grammar to a Bazel packages.  Generation is
managed by Bazel, and the output no longer needs to be committed.
Updates can be re-processed by `yarn kbn build` or `yarn kbn watch`.

Related to elastic#85341
Closes elastic#17284
@jbudz jbudz mentioned this issue Sep 10, 2021
Merged
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Timelion Timelion app and visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Es query] Move to package lizozom/kibana
[timelion] Move grammar to package jbudz/kibana
9 participants
@tylersmalley @wylieconlon @timroes @lukeelmers @lizozom @jbudz @Bargs @ppisljar @elasticmachine