[timelion] Move grammar to package #111881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the timelion grammar to a Bazel packages. Generation is managed by Bazel, and the output no longer needs to be committed. Updates can be re-processed by `yarn kbn build` or `yarn kbn watch`. Related to elastic#85341 Closes elastic#17284
jbudz
added
Team:Operations
Merged
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
|
@elastic/kibana-vis-editors this moves grammar generation from pegjs 0.9 to peggy 1.2. I did cursory manual testing, but I'm not sure how far our test coverage extends. If there's any more complicated tests that you're able to validate it would be appreciated. |
|
@elasticmachine merge upstream |
VladLasitsa
approved these changes
Sep 13, 2021
stratoula
approved these changes
Sep 13, 2021
tylersmalley
approved these changes
Sep 15, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Sep 16, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jbudz
added a commit
that referenced
this pull request
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the timelion grammar to a Bazel packages. Generation is
managed by Bazel, and the output no longer needs to be committed.
Updates can be re-processed by
yarn kbn buildoryarn kbn watch.Related to #85341
Closes #17284