-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to peggy from pegjs #97914
Migrate to peggy from pegjs #97914
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
Pinging @elastic/kibana-app (Team:KibanaApp) |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / jest / Jest Tests.src/core/server/saved_objects/service/lib.SavedObjectsRepository #find errors throws when KQL filter syntax is invalidStandard Out
Stack Trace
Kibana Pipeline / jest / Jest Tests.src/core/server/saved_objects/service/lib.SavedObjectsRepository #find search dsl accepts KQL KueryNode filter and passes KueryNode to getSearchDslStandard Out
Stack Trace
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/lens/public/editor_frame_service/editor_frame.editor_frame initialization should render the resulting expression using the expression rendererStandard Out
Stack Trace
and 311 more failures, only showing the first 3. Metrics [docs]Module Count
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
@lukeelmers I wasn't aware of the existing efforts there, but I agree that we need to update the grammars automatically. The test failures here are happening because I failed to build the KQL grammar with the right command. Closing this PR because it's pretty risky until we have automated builds. |
This PR is a riskier but more complete migration away from pegjs to peggyjs, which is an API compatible fork that is being maintained.
Replaces #97906 if we choose to implement the full version.
For reviewers on app-services who might be concerned about the large diffs in your apps: this happened because nobody regenerated the grammar when pegjs 0.10.0 was released. If you regenerate the grammar on master you will see the same large diffs, this PR just commits the changes.
Closes #97504