Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] InstrumentsConcurrencyTests testLockingWhenRegistering failing #100251

Closed
piergm opened this issue Oct 4, 2023 · 2 comments · Fixed by #100518
Closed

[CI] InstrumentsConcurrencyTests testLockingWhenRegistering failing #100251

piergm opened this issue Oct 4, 2023 · 2 comments · Fixed by #100518
Assignees
@thecoop
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI

Comments

@piergm
Copy link
Member

piergm commented Oct 4, 2023

Build scan:
https://gradle-enterprise.elastic.co/s/huqrhtvtbvgx6/tests/:modules:apm:test/org.elasticsearch.telemetry.apm.internal.metrics.InstrumentsConcurrencyTests/testLockingWhenRegistering
Reproduction line:

./gradlew ':modules:apm:test' --tests "org.elasticsearch.telemetry.apm.internal.metrics.InstrumentsConcurrencyTests.testLockingWhenRegistering" -Dtests.seed=E5AD40A2249185B8 -Dtests.locale=es-MX -Dtests.timezone=America/Argentina/San_Luis -Druntime.java=17

Applicable branches:
main

Reproduces locally?:
No

Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.telemetry.apm.internal.metrics.InstrumentsConcurrencyTests&tests.test=testLockingWhenRegistering
Failure excerpt:

java.lang.AssertionError: 
Expected: <WAITING>
     but: was <TERMINATED>

  at __randomizedtesting.SeedInfo.seed([E5AD40A2249185B8:DB8946D029FCC50E]:0)
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
  at org.junit.Assert.assertThat(Assert.java:956)
  at org.junit.Assert.assertThat(Assert.java:923)
  at org.elasticsearch.telemetry.apm.internal.metrics.InstrumentsConcurrencyTests.lambda$testLockingWhenRegistering$2(InstrumentsConcurrencyTests.java:102)
  at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:1196)
  at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:1169)
  at org.elasticsearch.telemetry.apm.internal.metrics.InstrumentsConcurrencyTests.testLockingWhenRegistering(InstrumentsConcurrencyTests.java:102)
  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:568)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:833)
@piergm piergm added :Core/Infra/Core Core issues without another label >test-failure Triaged test failures from CI labels Oct 4, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Oct 4, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@danielmitterdorfer danielmitterdorfer mentioned this issue Oct 5, 2023
Merged
@DaveCTurner DaveCTurner mentioned this issue Oct 9, 2023
Merged
@edsavage
Copy link
Contributor

edsavage commented Oct 9, 2023

Another occurrence, on 8.11 - https://gradle-enterprise.elastic.co/s/u7gxuagjfyimu/tests/task/:modules:apm:test/details/org.elasticsearch.telemetry.apm.internal.metrics.InstrumentsConcurrencyTests/testLockingWhenRegistering?top-execution=1

@thecoop thecoop self-assigned this Oct 9, 2023
@thecoop thecoop mentioned this issue Oct 9, 2023
Merged
elasticsearchmachine pushed a commit that referenced this issue Oct 9, 2023
@thecoop
Fix race condition in InstrumentsConcurrencyTests (#100518)
d81dbfa 
Fix a race condition between the two threads in
InstrumentsConcurrencyTests. If the second thread gets the lock first,
the test fails.

Fixes #100251
@DaveCTurner DaveCTurner mentioned this issue Oct 10, 2023
Closed
thecoop added a commit to thecoop/elasticsearch that referenced this issue Oct 11, 2023
@thecoop
Fix race condition in InstrumentsConcurrencyTests (elastic#100518)
27b29cf 
Fix a race condition between the two threads in
InstrumentsConcurrencyTests. If the second thread gets the lock first,
the test fails.

Fixes elastic#100251
thecoop added a commit that referenced this issue Oct 11, 2023
@thecoop
Backport InstrumentsConcurrencyTests fix to 8.11 (#100660)
1a683d1 
This backports #100518  to 8.11
Fixes #100251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thecoop thecoop

Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix race condition in InstrumentsConcurrencyTests thecoop/elasticsearch
4 participants
@thecoop @edsavage @elasticsearchmachine @piergm