Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport InstrumentsConcurrencyTests fix to 8.11 #100660

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Oct 11, 2023

Backport #100518 to 8.11. This fixes #100587

Fix a race condition between the two threads in
InstrumentsConcurrencyTests. If the second thread gets the lock first,
the test fails.

Fixes elastic#100251
@thecoop thecoop added >bug >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label backport v8.11.0 labels Oct 11, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@thecoop thecoop changed the base branch from main to 8.11 October 11, 2023 08:19
@thecoop thecoop removed the v8.12.0 label Oct 11, 2023
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop merged commit 1a683d1 into elastic:8.11 Oct 11, 2023
15 checks passed
@thecoop thecoop deleted the instruments-test-race-8.11 branch October 11, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >bug :Core/Infra/Core Core issues without another label >test Issues or PRs that are addressing/adding tests v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] InstrumentsConcurrencyTests testLockingWhenRegistering failing
3 participants