-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Universal Profiling as Enterprise feature #100333
Enable Universal Profiling as Enterprise feature #100333
Conversation
With this commit we ensure that Universal Profiling can only be used with an Enterprise license.
Pinging @elastic/profiling (Team:Universal Profiling) |
Hi @danielmitterdorfer, I've created a changelog YAML for you. |
Test instructions:
|
} | ||
return Collections.singletonList(createLicenseChecker()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #97546 (comment) for context on why we are returning the license checker in all cases (but no other components).
@elasticsearchmachine run elasticsearch-ci/part-1 |
BWC tests were flaky. @elasticsearchmachine run elasticsearch-ci/bwc |
@elasticsearchmachine run elasticsearch-ci/part-2 |
The curl command works as expected together with your ES startup (fresh data). But when starting ES with Also the other way round, first using basic and then trial, leaves me with a 403 response. I guess this behavior has nothing to do with this PR, but want to make sure that this is expected. |
Ah, good catch but that's expected. The license is preserved in the cluster state and it's not that you can change the license at will with a dev cluster using the |
Also, I'm gonna look into these failing CI checks. Unfortunately most of the times it's just caused by unrelated flaky tests but I'll investigate these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, testing the PR works as expected.
@elasticsearchmachine run elasticsearch-ci/part-3 |
@elasticsearchmachine run elasticsearch-ci/bwc |
@elasticsearchmachine run elasticsearch-ci/part-2 |
@elasticmachine merge upstream |
build timed out (CI infrastructure issue) @elasticsearchmachine run elasticsearch-ci/part-1 |
)" This reverts commit dfaec0d.
With this commit we ensure that Universal Profiling can only be used with an Enterprise license.