Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partition style chart (pie, treemap, etc) tooltips cause scrollbars to appear. #596

Closed
cchaos opened this issue Mar 23, 2020 · 4 comments · Fixed by #647 or elastic/kibana#69126
Closed

Partition style chart (pie, treemap, etc) tooltips cause scrollbars to appear. #596

cchaos opened this issue Mar 23, 2020 · 4 comments · Fixed by #647 or elastic/kibana#69126
Assignees
@nickofthyme
Labels
bug Something isn't working released Issue released publicly :tooltip Related to hover tooltip

Comments

@cchaos
Copy link
Contributor

cchaos commented Mar 23, 2020

Describe the bug
Partition style chart (pie, treemap, etc) tooltips cause scrollbars to appear.

To Reproduce
Steps to reproduce the behavior:

  1. Make a treemap not in Storybook
  2. Hover a treemap piece

Expected behavior
No scrollbars should appear

Screenshots
Screen Capture on 2020-03-23 at 15-59-17
@cchaos cchaos added the bug Something isn't working label Mar 23, 2020
@monfera
Copy link
Contributor

monfera commented Mar 23, 2020

Thanks for the report Caroline - @markov00 have you got a hunch on this one?

@markov00
Copy link
Member

That is something that was already there also with the XY chart, it's visible in our storybook (see #453)
Unfortunately this happens because of the css used to correctly display the tooltip. I will investigate on it a bit more to see if we can fix that behaviour changing the current tooltip behaviour

@markov00 markov00 self-assigned this Mar 25, 2020
@markov00 markov00 added the :tooltip Related to hover tooltip label Mar 26, 2020
@wylieconlon wylieconlon mentioned this issue Mar 27, 2020
Open
17 tasks
@abdul737
Copy link

Having the same issue

@nickofthyme nickofthyme assigned nickofthyme and unassigned markov00 Apr 22, 2020
@nickofthyme nickofthyme mentioned this issue Apr 23, 2020
Merged
3 tasks
@markov00
Copy link
Member

🎉 This issue has been resolved in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 28, 2020
@nickofthyme nickofthyme mentioned this issue May 27, 2020
Merged
4 tasks
nickofthyme added a commit that referenced this issue May 28, 2020
@nickofthyme
feat(tooltip): improve positioning with popperjs (#651)
6512950 
- configurable placement
- configurable fallback placement
- configurable tooltip boundary element
- improved placement options
- custom tooltip component

related to #596
markov00 pushed a commit that referenced this issue May 28, 2020
@semantic-release-bot
chore(release): 19.4.0 [skip ci]
bd65244 
# [19.4.0](v19.3.0...v19.4.0) (2020-05-28)

### Bug Fixes

* **partition:** consider legendMaxDepth on legend size ([#654](#654)) ([9429dcf](9429dcf)), closes [#639](#639)

### Features

* **partition:** enable grooves in all group layers ([#666](#666)) ([f5b4767](f5b4767))
* **partition:** linked text overflow avoidance ([#670](#670)) ([b6e5911](b6e5911)), closes [#633](#633)
* **partition:** monotonic font size scaling ([#681](#681)) ([ea2489b](ea2489b)), closes [#661](#661)
* **tooltip:** improve positioning with popperjs ([#651](#651)) ([6512950](6512950)), closes [#596](#596)
@markov00 markov00 mentioned this issue Jun 15, 2020
Merged
1 task
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 19.4.0 [skip ci]
747af29 
# [19.4.0](elastic/elastic-charts@v19.3.0...v19.4.0) (2020-05-28)

### Bug Fixes

* **partition:** consider legendMaxDepth on legend size ([opensearch-project#654](elastic/elastic-charts#654)) ([20cc6ec](elastic/elastic-charts@20cc6ec)), closes [opensearch-project#639](elastic/elastic-charts#639)

### Features

* **partition:** enable grooves in all group layers ([opensearch-project#666](elastic/elastic-charts#666)) ([b1bdfb3](elastic/elastic-charts@b1bdfb3))
* **partition:** linked text overflow avoidance ([opensearch-project#670](elastic/elastic-charts#670)) ([59617db](elastic/elastic-charts@59617db)), closes [opensearch-project#633](elastic/elastic-charts#633)
* **partition:** monotonic font size scaling ([opensearch-project#681](elastic/elastic-charts#681)) ([d46767c](elastic/elastic-charts@d46767c)), closes [opensearch-project#661](elastic/elastic-charts#661)
* **tooltip:** improve positioning with popperjs ([opensearch-project#651](elastic/elastic-charts#651)) ([61d1d9a](elastic/elastic-charts@61d1d9a)), closes [opensearch-project#596](elastic/elastic-charts#596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
bug Something isn't working released Issue released publicly :tooltip Related to hover tooltip
Projects
None yet
Milestone
No milestone
5 participants
@cchaos @markov00 @monfera @abdul737 @nickofthyme