Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. finds while reviewing a branch #453

Open
monfera opened this issue Nov 20, 2019 · 2 comments
Open

Misc. finds while reviewing a branch #453

monfera opened this issue Nov 20, 2019 · 2 comments
Labels
:annotation Annotation (line, rect, text) related issue :chart Chart element related issue :colors colors related issue discuss To be discussed :tooltip Related to hover tooltip

Comments

@monfera
Copy link
Contributor

monfera commented Nov 20, 2019

These are not regressions, just questions or suggestions about specific items I run into while reviewing. I may add more, in the form of comments, if I run into more.

The legend shows values of the hovered item (a relatively rare interaction and redundant in that the tooltip shows these too; sometimes the legend shows totals or other aggregations for the whole shown dataset). It seems to show the value of the last item of the series when not hovering. I wasn't sure if it's intentional
image

We might want to introduce default text padding for the in-bar label and the legend value too

A scrollbar appears when hovering on the last two bars
image

Contrast readability conflict, on dark ink the text could invert. #454

Also, the label placement can't really work with small bars stacked, maybe it'd be best to skip a label if it's outside its own ink and there's some other ink there:
image

Wondering about the use of the non-monotonic interpolation eg. natural, as it often overshoots the target:
image

The overlap of area chart with point markers may be unintentional:
image

@monfera monfera added discuss To be discussed :chart Chart element related issue :styling Styling related issue labels Nov 20, 2019
@markov00 markov00 added :annotation Annotation (line, rect, text) related issue :colors colors related issue :tooltip Related to hover tooltip and removed :styling Styling related issue labels Mar 27, 2020
@nickofthyme
Copy link
Collaborator

nickofthyme commented Apr 22, 2020

@monfera can you break this issue into separate issues so we can track the work individually?

@monfera
Copy link
Contributor Author

monfera commented Apr 24, 2020

@nickofthyme if it's OK can we handle it as a meta-issue, or leave this task to the triager as several things might have been fixed since, otherwise it'd be just mechanical copy/paste work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:annotation Annotation (line, rect, text) related issue :chart Chart element related issue :colors colors related issue discuss To be discussed :tooltip Related to hover tooltip
Projects
None yet
Development

No branches or pull requests

3 participants