feat(partition): linked text overflow avoidance

[monfera]

Summary

Truncates linked label text to fit in the chart box (WIP)

Example with off-center pie chart to avoid centered special case:

It culls a link label altogether if

• its text has no horizontal room left
• the text would overflow the rectangular area vertically; eg. no linked label for the green Food... slice:
  

Closes #633

Checklist

Delete any items that are not applicable to this PR.

• Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
• This was checked for cross-browser compatibility, including a check against IE11
• Proper documentation or storybook story was added for features that require explanation or tutorials
• Unit tests were updated or added to match the most common scenarios

[monfera]

Removed the wip label as it has the vertical space feature as well.
The image tests capture the desired effect to a greater extent than unit tests could. I also have plans to revisit it for improvements, eg. more accurate maximalization of horizontal space.

The unit testing plan for a subsequent PR is the following:

• extract out and maybe rename the maximizer function which is basically a greedy search, gradient descent function
• switch to this function for the determination of font sizes for fill text, which currently iterates through the font sizes linearly, and not yet modular anyway
• the optimizer thus becomes exported, add unit tests for it

[codecov-io]

Codecov Report

Merging #670 into master will decrease coverage by 0.37%.
The diff coverage is 6.89%.

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   72.97%   72.60%   -0.38%     
==========================================
  Files         266      266              
  Lines        8634     8678      +44     
  Branches     1698     1710      +12     
==========================================
  Hits         6301     6301              
- Misses       2294     2338      +44     
  Partials       39       39              

Impacted Files	Coverage Δ
...hart_types/partition_chart/layout/config/config.ts	68.75% <ø> (ø)
...types/partition_chart/layout/types/config_types.ts	100.00% <ø> (ø)
...es/partition_chart/layout/types/viewmodel_types.ts	80.00% <ø> (ø)
...rtition_chart/layout/viewmodel/link_text_layout.ts	10.12% <0.00%> (-8.93%)	⬇️
src/utils/data_generators/simple_noise.ts	100.00% <ø> (ø)
src/utils/data_generators/data_generator.ts	44.44% <22.22%> (-10.73%)	⬇️
...ypes/partition_chart/layout/viewmodel/viewmodel.ts	89.23% <100.00%> (ø)
src/mocks/utils.ts	94.11% <100.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79e899...2f21442. Read the comment docs.

[markov00]

LGTM, I've added a comment to include the TSDoc for the monotonicMaximizer function as it's a little bit difficult to understand looking just at the function signature.

[markov00]

nit: Could you please add a jsdoc describing what this function does?
It's a little cryptic and I've difficulties understanding what is going on there

[markov00]

Please, also add the return type

[monfera]

Thanks Marco, will do, the upcoming PR deals with and extracts out this function

[nickofthyme]

Code and functionality all LGTM

[codecov-commenter]

Codecov Report

Merging #670 into master will decrease coverage by 0.37%.
The diff coverage is 6.89%.

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   72.97%   72.60%   -0.38%     
==========================================
  Files         266      266              
  Lines        8634     8678      +44     
  Branches     1698     1710      +12     
==========================================
  Hits         6301     6301              
- Misses       2294     2338      +44     
  Partials       39       39              

Impacted Files	Coverage Δ
...hart_types/partition_chart/layout/config/config.ts	68.75% <ø> (ø)
...types/partition_chart/layout/types/config_types.ts	100.00% <ø> (ø)
...es/partition_chart/layout/types/viewmodel_types.ts	80.00% <ø> (ø)
...rtition_chart/layout/viewmodel/link_text_layout.ts	10.12% <0.00%> (-8.93%)	⬇️
src/utils/data_generators/simple_noise.ts	100.00% <ø> (ø)
src/utils/data_generators/data_generator.ts	44.44% <22.22%> (-10.73%)	⬇️
...ypes/partition_chart/layout/viewmodel/viewmodel.ts	89.23% <100.00%> (ø)
src/mocks/utils.ts	94.11% <100.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79e899...2f21442. Read the comment docs.

[markov00]

🎉 This PR is included in version 19.4.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀