This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
fix: use golangci-lint in favour of go-critic #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected by golangci-lint
9 tasks
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 5 |
| Passed | 67 |
| Skipped | 20 |
| Total | 92 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / fleet_agent_endpoint_integration / Un-enrolling Elastic Agent stops Elastic Endpoint – Agent Endpoint Integration - Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / Un-enrolling the centos agent – Fleet Mode Agent - Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / Un-enrolling the debian agent – Fleet Mode Agent - Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / Revoking the enrollment token for the centos agent – Fleet Mode Agent - Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / Revoking the enrollment token for the debian agent – Fleet Mode Agent
v1v
approved these changes
Jan 4, 2021
cachedout
approved these changes
Jan 4, 2021
|
The errors are also existing in master, so not related. Going to merge |
|
Did not mentioned here, but those errors seems related to a change in elasticsearch/kibana: It feels that kibana/elasticsearch are not creating Fleet setup throwing/raising an In tests:
In Kibana logs:
For a similar reason, any try to unenroll an agent fails with similar error:
In Kibana logs:
Would this PR be related? elastic/kibana#87053. Also reported by Kibana QA here: elastic/kibana#86864 |
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 4, 2021
* fix: remove var type as per golint's suggestion * chore: add golangci-lint precommit hook * chore: remove go-critic in fafvour of golangci-lint * chore: remove TOML hook * chore: add go-vet hook * fix: remove unused variable Detected by golangci-lint * fix: remove unused Go file, which caused lint errors
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 4, 2021
* fix: remove var type as per golint's suggestion * chore: add golangci-lint precommit hook * chore: remove go-critic in fafvour of golangci-lint * chore: remove TOML hook * chore: add go-vet hook * fix: remove unused variable Detected by golangci-lint * fix: remove unused Go file, which caused lint errors
mdelapenya
added a commit
that referenced
this pull request
Jan 4, 2021
…use golangci-lint in favour of go-critic (#550) backport for 7.x (#553) * chore: simplify jUnit format generation with gotestsum (#549) * fix: use golangci-lint in favour of go-critic (#550) * fix: remove var type as per golint's suggestion * chore: add golangci-lint precommit hook * chore: remove go-critic in fafvour of golangci-lint * chore: remove TOML hook * chore: add go-vet hook * fix: remove unused variable Detected by golangci-lint * fix: remove unused Go file, which caused lint errors
mdelapenya
added a commit
that referenced
this pull request
Jan 4, 2021
…use golangci-lint in favour of go-critic (#550) backport for 7.10.x (#554) * chore: simplify jUnit format generation with gotestsum (#549) * fix: use golangci-lint in favour of go-critic (#550) * fix: remove var type as per golint's suggestion * chore: add golangci-lint precommit hook * chore: remove go-critic in fafvour of golangci-lint * chore: remove TOML hook * chore: add go-vet hook * fix: remove unused variable Detected by golangci-lint * fix: remove unused Go file, which caused lint errors
12 tasks
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It replaces
go-criticwithgolangci-lint, also adding go-vet (https://golang.org/cmd/vet/) and removing tomlv (no TOML files in the project) hooks.In the process of testing each hook we identified minor flaws that we have fixed in this PR:
Why is it important?
Go-critic fails to be fetched on CI (a clean environment) because its dependency to
go-ruleguardseems to be broken after a package rename (See quasilyte/go-ruleguard#151).Go-criticproject also suggest using it undergolangci-lint: https://github.com/go-critic/go-criticChecklist
make noticein the proper directory)Author's Checklist