This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
chore: simplify jUnit format generation with gotestsum (#549) | fix: use golangci-lint in favour of go-critic (#550) backport for 7.x #553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: remove var type as per golint's suggestion * chore: add golangci-lint precommit hook * chore: remove go-critic in fafvour of golangci-lint * chore: remove TOML hook * chore: add go-vet hook * fix: remove unused variable Detected by golangci-lint * fix: remove unused Go file, which caused lint errors
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
|
Test | Results |
---|---|
Failed | 5 |
Passed | 55 |
Skipped | 6 |
Total | 66 |
Genuine test errors
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / Pre-Submit / Sanity checks / go vet – pre_commit.lint
- Name:
Initializing / Pre-Submit / Sanity checks / golangcilint – pre_commit.lint
- Name:
Initializing / End-To-End Tests / fleet_stand_alone_agent / [empty] – TEST-fleet.xml
- Name:
Initializing / End-To-End Tests / fleet_agent_endpoint_integration / [empty] – TEST-fleet.xml
- Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / [empty] – TEST-fleet.xml
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
|
Test | Results |
---|---|
Failed | 3 |
Passed | 43 |
Skipped | 20 |
Total | 66 |
Genuine test errors
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / fleet_agent_endpoint_integration / [empty] – TEST-fleet.xml
- Name:
Initializing / End-To-End Tests / fleet_stand_alone_agent / [empty] – TEST-fleet.xml
- Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / [empty] – TEST-fleet.xml
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: