-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Tuning] Port Scan Rules #4443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
Mikaayenson
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Thank you!
w0rk3r
approved these changes
Feb 5, 2025
r0ot
added a commit
to VigilantSec/detection-rules
that referenced
this pull request
Feb 5, 2025
* [Rule Tuning] Port Scan Rules (elastic#4443) * [New Hunt] General Kernel Manipulation (elastic#4403) * [New Hunt] General Kernel Manipulation * Update index.yml * [New Hunt] Persistence via PolicyKit (elastic#4406) * [New Hunt] Persistence via PolicyKit * ++ * [New Hunt] Persistence via Desktop Bus (D-Bus) (elastic#4407) * [Rule Tuning] Remote Execution via File Shares (elastic#4448) * [Rule Tuning] Tighten Up Elastic Defend Indexes - MacOS (elastic#4447) * tags (#4) Co-authored-by: peterydzynski <peter.rydzynski1@gmail.com> --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> Co-authored-by: Jonhnathan <26856693+w0rk3r@users.noreply.github.com> Co-authored-by: peterydzynski <peter.rydzynski1@gmail.com>
5 tasks
r0ot
added a commit
to VigilantSec/detection-rules
that referenced
this pull request
Feb 5, 2025
* [Rule Tuning] Port Scan Rules (elastic#4443) * [New Hunt] General Kernel Manipulation (elastic#4403) * [New Hunt] General Kernel Manipulation * Update index.yml * [New Hunt] Persistence via PolicyKit (elastic#4406) * [New Hunt] Persistence via PolicyKit * ++ * [New Hunt] Persistence via Desktop Bus (D-Bus) (elastic#4407) * [Rule Tuning] Remote Execution via File Shares (elastic#4448) * [Rule Tuning] Tighten Up Elastic Defend Indexes - MacOS (elastic#4447) * tags (#4) --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> Co-authored-by: Jonhnathan <26856693+w0rk3r@users.noreply.github.com> Co-authored-by: peterydzynski <peter.rydzynski1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These rules have been tuned several times, and in one tuning, I bricked the rule logic:
Through community slack, concerns about this rule were presented:
This PR addresses these issues by:
network_flow
event.action
field to ensure flow data captured by the NPC is used to trigger the rule. I kept PANW integration, as I checked rules such as this, which seem to be compatible with the sameevent.action
. I don't have a dataset to test this with myself, however.