[Rule Tuning] Some Tunings of several 8.9 rules #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aegrah
requested review from
w0rk3r,
shashank-elastic,
terrancedejesus and
eric-forte-elastic
Aegrah
commented
Jul 31, 2023
Aegrah
commented
Jul 31, 2023
This was referenced Aug 1, 2023
w0rk3r
approved these changes
Aug 2, 2023
| @@ -32,7 +32,7 @@ type = "new_terms" | |||
| query = ''' | |||
| host.os.type:linux and event.action:(creation or file_create_event or file_rename_event or rename) and | |||
| file.path:(/dev/shm/* or /usr/lib/*) and file.extension:so and | |||
| process.name:(* and not (5 or dockerd or dpkg or rpm or snapd)) | |||
| process.name: ( * and not ("5" or "dockerd" or "dpkg" or "rpm" or "snapd" or "exe" or "yum" or "vmis-launcher")) | |||
There was a problem hiding this comment.
When I was testing it, there were some cases where process.name didn't exist, therefore I added that back then - kept it there for now.
shashank-elastic
approved these changes
Aug 3, 2023
protectionsmachine
pushed a commit
that referenced
this pull request
Aug 3, 2023
* [Rule Tuning] Doing some quick tunings * updated_date bump * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_sysctl_enumeration.toml * Update rules/linux/persistence_init_d_file_creation.toml * Update rules/linux/persistence_rc_script_creation.toml * Update rules/linux/persistence_shared_object_creation.toml * deprecate rule * deprecate rule * Update execution_abnormal_process_id_file_created.toml * Update discovery_kernel_module_enumeration_via_proc.toml * Update discovery_linux_modprobe_enumeration.toml * Update execution_remote_code_execution_via_postgresql.toml * Update discovery_potential_syn_port_scan_detected.toml * Added 2 tunings, sorry I missed those.. * One more tune * Update discovery_suspicious_proc_enumeration.toml Removed changes from: - rules/linux/command_and_control_suspicious_network_activity_from_unknown_executable.toml - rules/linux/discovery_kernel_module_enumeration.toml - rules/linux/execution_abnormal_process_id_file_created.toml - rules/linux/persistence_cron_job_creation.toml - rules/linux/persistence_init_d_file_creation.toml - rules/linux/persistence_message_of_the_day_creation.toml - rules/linux/persistence_rc_script_creation.toml - rules/linux/persistence_shared_object_creation.toml - rules/linux/persistence_systemd_scheduled_timer_created.toml - rules/linux/persistence_systemd_service_creation.toml (selectively cherry picked from commit a7ff449)
protectionsmachine
pushed a commit
that referenced
this pull request
Aug 3, 2023
* [Rule Tuning] Doing some quick tunings * updated_date bump * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_sysctl_enumeration.toml * Update rules/linux/persistence_init_d_file_creation.toml * Update rules/linux/persistence_rc_script_creation.toml * Update rules/linux/persistence_shared_object_creation.toml * deprecate rule * deprecate rule * Update execution_abnormal_process_id_file_created.toml * Update discovery_kernel_module_enumeration_via_proc.toml * Update discovery_linux_modprobe_enumeration.toml * Update execution_remote_code_execution_via_postgresql.toml * Update discovery_potential_syn_port_scan_detected.toml * Added 2 tunings, sorry I missed those.. * One more tune * Update discovery_suspicious_proc_enumeration.toml Removed changes from: - rules/linux/command_and_control_suspicious_network_activity_from_unknown_executable.toml - rules/linux/discovery_kernel_module_enumeration.toml - rules/linux/execution_abnormal_process_id_file_created.toml - rules/linux/persistence_cron_job_creation.toml - rules/linux/persistence_init_d_file_creation.toml - rules/linux/persistence_message_of_the_day_creation.toml - rules/linux/persistence_rc_script_creation.toml - rules/linux/persistence_shared_object_creation.toml - rules/linux/persistence_systemd_scheduled_timer_created.toml - rules/linux/persistence_systemd_service_creation.toml (selectively cherry picked from commit a7ff449)
protectionsmachine
pushed a commit
that referenced
this pull request
Aug 3, 2023
* [Rule Tuning] Doing some quick tunings * updated_date bump * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_sysctl_enumeration.toml * Update rules/linux/persistence_init_d_file_creation.toml * Update rules/linux/persistence_rc_script_creation.toml * Update rules/linux/persistence_shared_object_creation.toml * deprecate rule * deprecate rule * Update execution_abnormal_process_id_file_created.toml * Update discovery_kernel_module_enumeration_via_proc.toml * Update discovery_linux_modprobe_enumeration.toml * Update execution_remote_code_execution_via_postgresql.toml * Update discovery_potential_syn_port_scan_detected.toml * Added 2 tunings, sorry I missed those.. * One more tune * Update discovery_suspicious_proc_enumeration.toml Removed changes from: - rules/linux/command_and_control_suspicious_network_activity_from_unknown_executable.toml - rules/linux/discovery_kernel_module_enumeration.toml - rules/linux/execution_abnormal_process_id_file_created.toml - rules/linux/persistence_cron_job_creation.toml - rules/linux/persistence_init_d_file_creation.toml - rules/linux/persistence_message_of_the_day_creation.toml - rules/linux/persistence_rc_script_creation.toml - rules/linux/persistence_shared_object_creation.toml - rules/linux/persistence_systemd_scheduled_timer_created.toml - rules/linux/persistence_systemd_service_creation.toml (selectively cherry picked from commit a7ff449)
protectionsmachine
pushed a commit
that referenced
this pull request
Aug 3, 2023
* [Rule Tuning] Doing some quick tunings * updated_date bump * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_sysctl_enumeration.toml * Update rules/linux/persistence_init_d_file_creation.toml * Update rules/linux/persistence_rc_script_creation.toml * Update rules/linux/persistence_shared_object_creation.toml * deprecate rule * deprecate rule * Update execution_abnormal_process_id_file_created.toml * Update discovery_kernel_module_enumeration_via_proc.toml * Update discovery_linux_modprobe_enumeration.toml * Update execution_remote_code_execution_via_postgresql.toml * Update discovery_potential_syn_port_scan_detected.toml * Added 2 tunings, sorry I missed those.. * One more tune * Update discovery_suspicious_proc_enumeration.toml (cherry picked from commit a7ff449)
protectionsmachine
pushed a commit
that referenced
this pull request
Aug 3, 2023
* [Rule Tuning] Doing some quick tunings * updated_date bump * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_sysctl_enumeration.toml * Update rules/linux/persistence_init_d_file_creation.toml * Update rules/linux/persistence_rc_script_creation.toml * Update rules/linux/persistence_shared_object_creation.toml * deprecate rule * deprecate rule * Update execution_abnormal_process_id_file_created.toml * Update discovery_kernel_module_enumeration_via_proc.toml * Update discovery_linux_modprobe_enumeration.toml * Update execution_remote_code_execution_via_postgresql.toml * Update discovery_potential_syn_port_scan_detected.toml * Added 2 tunings, sorry I missed those.. * One more tune * Update discovery_suspicious_proc_enumeration.toml (cherry picked from commit a7ff449)
protectionsmachine
pushed a commit
that referenced
this pull request
Aug 3, 2023
* [Rule Tuning] Doing some quick tunings * updated_date bump * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_sysctl_enumeration.toml * Update rules/linux/persistence_init_d_file_creation.toml * Update rules/linux/persistence_rc_script_creation.toml * Update rules/linux/persistence_shared_object_creation.toml * deprecate rule * deprecate rule * Update execution_abnormal_process_id_file_created.toml * Update discovery_kernel_module_enumeration_via_proc.toml * Update discovery_linux_modprobe_enumeration.toml * Update execution_remote_code_execution_via_postgresql.toml * Update discovery_potential_syn_port_scan_detected.toml * Added 2 tunings, sorry I missed those.. * One more tune * Update discovery_suspicious_proc_enumeration.toml (cherry picked from commit a7ff449)
protectionsmachine
pushed a commit
that referenced
this pull request
Aug 3, 2023
* [Rule Tuning] Doing some quick tunings * updated_date bump * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_modprobe_enumeration.toml * Update rules/linux/discovery_linux_sysctl_enumeration.toml * Update rules/linux/persistence_init_d_file_creation.toml * Update rules/linux/persistence_rc_script_creation.toml * Update rules/linux/persistence_shared_object_creation.toml * deprecate rule * deprecate rule * Update execution_abnormal_process_id_file_created.toml * Update discovery_kernel_module_enumeration_via_proc.toml * Update discovery_linux_modprobe_enumeration.toml * Update execution_remote_code_execution_via_postgresql.toml * Update discovery_potential_syn_port_scan_detected.toml * Added 2 tunings, sorry I missed those.. * One more tune * Update discovery_suspicious_proc_enumeration.toml (cherry picked from commit a7ff449)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To ensure that all of the rules I pushed last release won't flood telemetry, I went through all of them and made some necessary changes. In two weeks I will take another look to see how they are doing.
rules/_deprecated/command_and_control_connection_attempt_by_non_ssh_root_session.tomlis deprecated due to performance issues and its redundancy now that the reverse shell rules + suspicious network activity new_terms rule is out.