Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode support iconPath in QuickPickItem #89

Closed
wants to merge 1 commit into from
Closed

vscode support iconPath in QuickPickItem #89

wants to merge 1 commit into from
+21 −2

Conversation

rschnekenbu
Copy link

What it does

Support of iconPathc in QuickPickItem
VS Code 1.81 finalized the support for the iconPath in QuickPickItem. This is a partial support: full API support and the display of the ThemeIcon, but the display of the URI based icons is not yet available. This last part requires an update in monaco editor core

Fixes eclipse-theia#12883

Contributed on behalf of ST Microelectronics

How to test

  1. Install following extension:
  1. The extension provides a set of quick input samples. To test the new API, the following commands shall be used
  • Open the command palette
  • Select Quick Input Samples
  • Select Show QuickPick
  • 4 items shall be displayed, and only the 4th has an icon (Theme Icon is supported). The first and second should also get some icons, but this is not yet supported (requires a monaco-editor-core update so the monaco QuickPickItem will also have support for iconPath ).
    QuickPick

Review checklist

Reminder for reviewers

@rschnekenbu
Copy link
Author

53a45b4 fixes lint errors

@rschnekenbu
vscode support iconPath in QuickPickItem
ea74d6c 
fixes eclipse-theia#12883
VS Code 1.81 finalized the support for the iconPath in QuickPickItem. This is a partial support: full API support and the display of the ThemeIcon, but the display of the URI based icons is not yet available. This last part requires an update in monaco editor core

Contributed on behalf of STMicroelectronics
@rschnekenbu
Copy link
Author

closed in favor of eclipse-theia#12945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vscode] finalized QuickPickItem iconPath API
1 participant
@rschnekenbu