Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode support iconPath in QuickPickItem #12945

Merged
merged 1 commit into from
Sep 27, 2023
Merged

vscode support iconPath in QuickPickItem #12945

merged 1 commit into from
Sep 27, 2023

Conversation

rschnekenbu
Copy link
Contributor

What it does

Support of iconPathc in QuickPickItem
VS Code 1.81 finalized the support for the iconPath in QuickPickItem. This is a partial support: full API support and the display of the ThemeIcon, but the display of the URI based icons is not yet available. This last part requires an update in monaco editor core

Fixes #12883

Contributed on behalf of ST Microelectronics

How to test

  1. Install following extension:
  1. The extension provides a set of quick input samples. To test the new API, the following commands shall be used
  • Open the command palette
  • Select Quick Input Samples
  • Select Show QuickPick
  • 4 items shall be displayed, and only the 4th has an icon (Theme Icon is supported). The first and second should also get some icons, but this is not yet supported (requires a monaco-editor-core update so the monaco QuickPickItem will also have support for iconPath ).
    QuickPick

Review checklist

Reminder for reviewers

@rschnekenbu rschnekenbu mentioned this pull request Sep 26, 2023
Closed
2 tasks
@JonasHelming
Copy link
Contributor

@msujew This would be crucial for the release, could you maybe have a look beforehand? (pretty small change)

tsmaeder
tsmaeder approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks O.K. and as far as we can test it (without the monaco upgrade) works as advertised.

packages/monaco/src/browser/monaco-quick-input-service.ts Show resolved Hide resolved
@JonasHelming JonasHelming removed the request for review from msujew September 27, 2023 08:51
@msujew msujew added vscode issues related to VSCode compatibility quick-open issues related to the quick-open labels Sep 27, 2023
@rschnekenbu
vscode support iconPath in QuickPickItem
077b08c 
fixes eclipse-theia#12883
VS Code 1.81 finalized the support for the iconPath in QuickPickItem. This is a partial support: full API support and the display of the ThemeIcon, but the display of the URI based icons is not yet available. This last part requires an update in monaco editor core

Contributed on behalf of STMicroelectronics

Update monaco-quick-input-service.ts

Add @monaco-uplift as requested by review
@rschnekenbu
Copy link
Contributor Author

I rebased the branch and squashed all commits so it can be safely merged once approved by the CI

@JonasHelming JonasHelming merged commit 7e3aa42 into eclipse-theia:master Sep 27, 2023
11 of 13 checks passed
@rschnekenbu rschnekenbu deleted the remi/12883 branch September 27, 2023 14:00
@vince-fugnitto vince-fugnitto added this to the 1.42.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew left review comments

@JonasHelming JonasHelming JonasHelming approved these changes

@tsmaeder tsmaeder tsmaeder approved these changes

Assignees
No one assigned
Labels
quick-open issues related to the quick-open vscode issues related to VSCode compatibility
Projects
PR Backlog
Archived in project
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.

[vscode] finalized QuickPickItem iconPath API
5 participants
@rschnekenbu @JonasHelming @msujew @tsmaeder @vince-fugnitto