Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] finalized QuickPickItem iconPath API #12883

Closed
Tracked by #12885
rschnekenbu opened this issue Aug 31, 2023 · 0 comments · Fixed by #12945
Closed
Tracked by #12885

[vscode] finalized QuickPickItem iconPath API #12883

rschnekenbu opened this issue Aug 31, 2023 · 0 comments · Fixed by #12945
Assignees
@rschnekenbu
Labels
vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

According to vscode release notes, quickPickItem iconPath property has been finalized

The API for icons in QuickPickItem has been finalized. You can now use the iconPath property to display icons in QuickPickItems.

QuickPickItem_iconPath
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Aug 31, 2023
@rschnekenbu rschnekenbu mentioned this issue Aug 31, 2023
Closed
5 tasks
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Sep 12, 2023
@rschnekenbu
vscode support iconPath in QuickPickItem
61c3f8e 
fixes eclipse-theia#12883
VS Code 1.81 finalized the support for the iconPath in QuickPickItem. This is a partial support: full API support and the display of the ThemeIcon, but the display of the URI based icons is not yet available. This last part requires an update in monaco editor core

Contributed on behalf of STMicroelectronics
@rschnekenbu rschnekenbu mentioned this issue Sep 12, 2023
Closed
2 tasks
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Sep 12, 2023
@rschnekenbu
vscode support iconPath in QuickPickItem
53a45b4 
fixes eclipse-theia#12883
VS Code 1.81 finalized the support for the iconPath in QuickPickItem. This is a partial support: full API support and the display of the ThemeIcon, but the display of the URI based icons is not yet available. This last part requires an update in monaco editor core

Contributed on behalf of STMicroelectronics
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Sep 26, 2023
@rschnekenbu
vscode support iconPath in QuickPickItem
8d0adfe 
fixes eclipse-theia#12883
VS Code 1.81 finalized the support for the iconPath in QuickPickItem. This is a partial support: full API support and the display of the ThemeIcon, but the display of the URI based icons is not yet available. This last part requires an update in monaco editor core

Contributed on behalf of STMicroelectronics
@rschnekenbu rschnekenbu mentioned this issue Sep 26, 2023
Merged
2 tasks
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Sep 26, 2023
@rschnekenbu
vscode support iconPath in QuickPickItem
ea74d6c 
fixes eclipse-theia#12883
VS Code 1.81 finalized the support for the iconPath in QuickPickItem. This is a partial support: full API support and the display of the ThemeIcon, but the display of the URI based icons is not yet available. This last part requires an update in monaco editor core

Contributed on behalf of STMicroelectronics
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Sep 27, 2023
@rschnekenbu
vscode support iconPath in QuickPickItem
077b08c 
fixes eclipse-theia#12883
VS Code 1.81 finalized the support for the iconPath in QuickPickItem. This is a partial support: full API support and the display of the ThemeIcon, but the display of the URI based icons is not yet available. This last part requires an update in monaco editor core

Contributed on behalf of STMicroelectronics

Update monaco-quick-input-service.ts

Add @monaco-uplift as requested by review
JonasHelming pushed a commit that referenced this issue Sep 27, 2023
@rschnekenbu
vscode support iconPath in QuickPickItem (#12945)
7e3aa42 
fixes #12883
VS Code 1.81 finalized the support for the iconPath in QuickPickItem. This is a partial support: full API support and the display of the ThemeIcon, but the display of the URI based icons is not yet available. This last part requires an update in monaco editor core

Contributed on behalf of STMicroelectronics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschnekenbu rschnekenbu

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
2 participants
@rschnekenbu @vince-fugnitto