Upgrade to Monaco 0.20.0

[RomanNikitenko]

What it does

• upgrade to Monaco 0.20.0 upgrade to Monaco 0.20.0 #7697

TODO

• fix bugs detected by tests
• align signatures for monaco/index.d.ts
• align ConfigurationChangeEvent with VS Code
• check that editor configurations are aligned
• check if we can revert hotfix for IME support Stop dispatching to keybindings in editing coposition text. #6673
• update font if fontInfo was changed only, see for details
• compareEntries should be revisited. See [monaco][quick-open] Using fuzzySort: true throws an error #7899 for more details
  • investigated [monaco][quick-open] Using fuzzySort: true throws an error #7899 (comment)
  • provided separate PR Sort for quick open entries respecting highlight information #8185
• revert Stick to vscode-languageserver@6.0.0-next.1 #6607 and revisit Content assistant for tasks.json is broken #6542 (comment)
  • done in another PR remove unused resolution for vscode-json-languageserver #8132

How to test

• test language features with VS Code extension:
  • test that features are available in the editor context menu and in quick command palette (automated)
  • a declaration is revealed when following the reference (automated)
  • focus belongs to a proper editor after following a reference (for internal and outside references, from editor to editor preview and view versa) (automated)
  • reference peek is still opened after following a reference (for internal and outside references, from editor to editor preview and view versa) (automated)
  • esc closes reference peek widget (automated)
  • completion items are properly resolved and inserted (automated)
  • focus belongs to a proper editor on peek definition (for internal and outside references, from editor to editor preview and view versa) (automated)
  • check that rename work inside the file and across files (automated)
  • check that arguments are proposed by the signature help (automated)
  • check that hover is present with properly rendered docs (automated)
  • check that symbol occurrences is highlighted when a declaration or reference is selected (automated)
  • check that go to (type|implementation) definition works properly, i.e. definition is revealed (automated)
  • check that code lens work properly (automated)
    • run/debug code lenses: https://github.com/kasecato/vscode-javadebug-sample. One has to install vscode java, debug and test extensions.
  • check that code actions work properly (quick fixes) (automated)
  • check that document and selection formatting work properly (automated)
  • check color provider with css colors
  • check link provider with links in html
  • check that folding ranges are properly provided for js, css and html
  • check go to symbol command
  • check open workspace symbol command
• test quick palette:
  • proper keys are displayed for the quick command palette, i.e. they are displayed and a corresponding Monaco command can be triggered by such keybinding
  • use sample vscode extension
  • use fuzzy search
• test vscode tree view (that context keys work properly)
• test plugin editor decorations, for example with power mode extension
• test debug console input editor
• test debug breakpoint editor
• test that preferences are propagated as config key values: change editor preferences and check whether they are reflected
• test language auto detection
• test edit menu with editor
• test selection menu with editor
• test editor context menu
• smoke test some VS Code extensions like go, python, just use editor for a bit, check backend and frontend logs for errors
• test manually task related functionality
  - done Upgrade to Monaco 0.20.0 #8010 (comment)

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

@RomanNikitenko let me know if you need any input to move it forward, I'm going to start looking into dropping monaco-languageclient later this week, but it would be good to have this PR in first.

[RomanNikitenko]

@RomanNikitenko let me know if you need any input to move it forward, I'm going to start looking into dropping monaco-languageclient later this week, but it would be good to have this PR in first.

I'm working on ConfigurationChangeEvent alignment with VS Code at the moment. It should fix some tests as well.
I'll try to speed up the process...

[RomanNikitenko]

I had to pause my work on the issue because of some urgent issues on our side.
I think I am able to come back and continue to work in a couple of days...

I'm really sorry for the delay.

[akosyakov]

I'm really sorry for the delay.

It is fine. I think we will land removing monaco-langaugeclient only in 1.5.0 (in beginning of August).

[akosyakov]

@RomanNikitenko I will spend this week adding more automated tests. Maybe also doing a follow-up PR for #7608 based on your PR.

[RomanNikitenko]

I'm working on ConfigurationChangeEvent alignment with VS Code at the moment.

[RomanNikitenko]

Working on editor configurations alignment.

[RomanNikitenko]

I provided a separate PR #8185 as possible solution for compareEntries function problem as we have the issue for that #7899

[RomanNikitenko]

Tested Selection menu:

• checked that items are aligned with the corresponding VS Code items (at previous upgrade we had to align them)
• all Selection menu actions work as expected for me for an open editor, except Keybinding collision between 'Toggle Plugins View' and 'Select All Occurrences' #7612 (comment), but it's not related to the Monaco upgrade and actual for master branch as well.

[RomanNikitenko]

Tested Tasks related functionality:

• task schema support at creating a new configuration
• Problems view displays warnings for a wrong configuration in a tasks.json file
• Terminal -> Run Task menu displays configured, detected and recently used tasks
• I was able to run a task from all categories (configured, detected and recently used)
• codicon-gear is displayed for a selected item
• Configure Tasks action allows to open the corresponding config file and a configuration is ready for editing
• hover Configure Task is displayed when select codicon-gear
• the corresponding tasks.json file is open at click on codicon-gear and the configuration of selected task is available for editing
• changes for presentation field of a configuration is applied correctly
• I don't see any regression for Run Last Task, Show Running Tasks, Restart Running Task, Terminate Task, Run Selected Text actions

[RomanNikitenko]

tests sometimes are failed, sometimes are successful on ci for my PR.
I don't know if it's unstable only for my branch.

@akosyakov
could you help with testing to detect real problems?
I'm going to focus on the PR to finalize upgrade Monaco.
thanks in advance!

[akosyakov]

@RomanNikitenko I will look tomorrow!

[akosyakov]

I've rebased the PR and resolved #8010 (comment). I would like to merge it (if tests are green) and move to implement semantic highligting support in the plugin system. Does anyone has objections or would you like to test it more? @eclipse-theia/ecd-theia-committers I can open a PR against this PR if so.

[benoitf]

merge it as soon as possible so it can fit in upcoming release and it let some time to fix some bugs before cutting the release

[akosyakov]

Unfortunately tests are not passing with Node.js 12. I will check what is wrong.

[akosyakov]

@RomanNikitenko semantic of editor.action.rename was changed, before it will await till edits are applied, now it only awaits till edits are produced. I am going to await instead till the document actually has a renamed symbol to get rid of time out.

That's unfortunately won't fix other tests. They seem to be affected by rename test but not because of failure. A rather a fix which did last week that models without editors should be auto saved not opened. I will try to disable auto saving before tests to see whether it helps.

[akosyakov]

Disabling auto save of dirty models without editors for tests helped. I will wait for builds and if they are green will merge. (Besides #8360, since it was failing before as well).

[akosyakov]

Nope tests are still failing. I will debug more on Monday why models get persisted implicitly by tests.

[akosyakov]

I was able to track down the bug in how we apply bulk edits now. There are 7 edits during rename for variable and references. We don't group them and apply atomically to the same model, but each in own tick, so revert get canceled and consequent tests are using the wrong model.

[akosyakov]

I fixed bulk edits in the last commit and adjusted test expectations to await a single edit operation on rename or fail.

[azatsarynnyy]

Thank you @akosyakov for fixing it!