remove unused resolution for vscode-json-languageserver #8132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
force-pushed
the
ak/remove_unused_resolution
branch
from
cd9de1b
to
cd8dc43
Compare
we don't depend on vscode-json-languageserver anymore Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
vince-fugnitto
force-pushed
the
ak/remove_unused_resolution
branch
from
cd8dc43
to
9c033a8
Compare
vince-fugnitto
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
The changes look good to me, I verified using yarn why vscode-json-languageserver:
$ yarn why vscode-json-languageserver
yarn why v1.22.4
[1/4] Why do we have the module "vscode-json-languageserver"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
error We couldn't find a match!
Done in 1.05s.
evinfug@elx7849163
kittaakos
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
It looks good to me 👍
Thanks for the update, @vince-fugnitto
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
we don't depend on vscode-json-languageserver anymore
How to test
yarn why vscode-json-languageservershould not find anythingReview checklist
Reminder for reviewers