Increase specificity of Output styles

[gbodeen]

Signed-off-by: Gabriel Bodeen gabriel.bodeen@ericsson.com

What it does

Fixes #9110.

As noted in a comment on the issue, git-bisect shows the regression was introduced in this commit, part of the PR where @theia/monaco-editor-core was upgraded from 0.19.0 to 0.20.0.

The cause is that in the upgraded Monaco, the editor token colors stylesheet is lazy-loaded and only attached to the DOM after the first editor is attached. So the CSS classes affecting the output are now loaded in the reverse order to what was originally expected.

The upstream fix is included as of v0.21.x, so if a PR such as this one going to 0.23.x is merged it will resolve the problem.

In the meantime, the immediate problem in the Output package can be resolved simply by increasing the specificity of the CSS selector, and it will not need to be reverted after a Monaco upgrade.

How to test

1. View > Output in the menus to open the Output widget if it is not visible. In the dropdown output channel list, select API Sample: my test channel.
2. On this branch, you'll see:

3. Versus master where you'll currently see:

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[gbodeen]

Hi -
The review guidelines mention the change log and licenses for new files (but not for existing files).

• Is a change log entry needed for something this minor?
• Does the license on the modified file need the current year included?

[vince-fugnitto]

@gbodeen thank you for the contribution, please be sure to sign the Eclipse Contributor Agreement (ECA) with the same email as your authorship (it currently fails one of our CI checks).

As for your questions :)

Is a change log entry needed for something this minor?

While an entry is most welcome, it is not necessarily necessary at this moment as we do a changelog pass before a release (ex: #9412).

Does the license on the modified file need the current year included?

There is no requirement to modify the license header, it only needs to be added when the file is first created.

[gbodeen]

please be sure to sign the Eclipse Contributor Agreement (ECA) with the same email as your authorship (it currently fails one of our CI checks).

OK, I was able to sign the agreement this morning.

[vince-fugnitto]

I confirmed that the updates fix the issue for error and warning output.
I also noticed that (like you said), the issue comes from monaco where it overrides the theia-output styling with mtk{n} styling.