Add support for preferences schema provided by a plug-in in a manifest file #3159
Conversation
akurinnoy
requested review from
evidolob,
akosyakov,
mmorhun and
AndrienkoAleksandr
| props.push(property); | ||
| } | ||
| } | ||
| this.validateFunction = new Ajv().compile(this.combinedSchema); |
There was a problem hiding this comment.
please refactor that it is called only once from the constructor, not for each contribution
There was a problem hiding this comment.
Thanks for the review!
My point here is to be able to validate a plugin schema too. Do we have another way to validate it?
There was a problem hiding this comment.
sure, you can call it from setSchema as well
just refactor it in a way that it is called once from the constructor and on each call of setSchema
There was a problem hiding this comment.
It is already called once from the constructor since setSchema is called there. Or maybe I missed something?
There was a problem hiding this comment.
it is called in forEach loop for each contribution
There was a problem hiding this comment.
thanks, got it! I'll refactor this
| @@ -96,6 +85,26 @@ export class PreferenceSchemaProvider extends PreferenceProvider { | |||
| return this.preferences; | |||
| } | |||
|
|
|||
| setSchema(schema: PreferenceSchema, updateValidation: boolean = true): void { | |||
There was a problem hiding this comment.
How abou, instead of adding internal options to public APIs extract 2 methods:
setSchema(schema: PreferenceSchema): void {
this.doSetSchema(schema);
this.updateValidate();
}
protected doSetSchema() ... // updates combined schema
protected updateValidate() ... // updates validate functionand call doSetSchema and updateValidate from the constructor instead of setSchema?
There was a problem hiding this comment.
yes, this will be better, I'm updating the PR
and consolidate it with existing ones Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
…in init Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
fixes eclipse-che/che#9990