plugin-hosted: fix loading sequence of plugin API initialisation #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sun Tan <sutan@redhat.com>
|
PR link being #2227 |
|
The problem same as preferences has, we should pass preferences and query parameters on |
|
#3159 should fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing a backend plugin and using
theia.env.getQueryParameteris failing because of loading sequence of plugin API initialisation.With this code sample https://github.com/AndrienkoAleksandr/testQuery/blob/master/src/testQuery-backend-plugin.ts#L9, and passing parameter to the Theia url is failling logging the query parameters passed.
This PR is fixing it.