Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIPTheia] Add support for preferences schema from contribution point of a manifest file #9990

Closed
akurinnoy opened this issue Jun 11, 2018 · 2 comments · Fixed by eclipse-theia/theia#3159
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@akurinnoy
Copy link
Contributor

akurinnoy commented Jun 11, 2018

Description

A plugin should be able to provide its own preferences schema. We should implement a mechanism which parses and respects the scheme provided by a plugin.

  1. Describe the schema in json file
  2. Point the file location in package.json [TODO define the configuration in package.json]
  3. Plugin meta data handles the value in package json, proceses and passes along with other plugin metadata
@akurinnoy akurinnoy added kind/enhancement A feature request - must adhere to the feature request template. team/ide2 labels Jun 11, 2018
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Jun 18, 2018
@ashumilova ashumilova added sprint/current status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Jun 21, 2018
@AndrienkoAleksandr AndrienkoAleksandr added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Jun 23, 2018
@AndrienkoAleksandr
Copy link
Contributor

I'm going to PTO, so summary about current state:
Working branch: https://github.com/theia-ide/theia/tree/CHE-9990-2
Samples (in dirty development state): https://github.com/theia-demo-plugins/theia-frontend-plugin/tree/workspaceConfigSamples;
Done: parsed preference chema from plugin contribution point in the manifest file, created consolidated configuration for extensions and plugins based on extension pref chema and plugin pref chema.
Remaining stuff:

@AndrienkoAleksandr AndrienkoAleksandr removed the status/in-progress This issue has been taken by an engineer and is under active development. label Sep 25, 2018
@akurinnoy akurinnoy self-assigned this Oct 11, 2018
@evidolob evidolob self-assigned this Oct 11, 2018
evidolob added a commit to eclipse-theia/theia that referenced this issue Oct 11, 2018
…in init

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
akurinnoy pushed a commit to eclipse-theia/theia that referenced this issue Oct 11, 2018
…in init

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
akurinnoy pushed a commit to eclipse-theia/theia that referenced this issue Oct 12, 2018
…in init

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
akurinnoy pushed a commit to eclipse-theia/theia that referenced this issue Oct 12, 2018
…in init

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants