fix: configure tasks from open task quick pick #13367
Conversation
| @@ -182,6 +182,7 @@ export class QuickOpenTask implements QuickAccessProvider { | |||
| picker.matchOnDescription = true; | |||
| picker.ignoreFocusOut = false; | |||
| picker.items = this.items; | |||
| picker.onDidTriggerItemButton(({ item }) => this.onDidTriggerGearIcon(item as QuickPickItem)); | |||
There was a problem hiding this comment.
It seems odd that we have to case here, but not below. Any idea why?
There was a problem hiding this comment.
The two methods have different signatures 😄
Here the item can be a separator as well, even if it won't happen (separators won't have buttons that will trigger this method). However, to make this nicer I updated the code and added a check here, instead.
There was a problem hiding this comment.
That was the question: is it true that one time the button item can be a separator as well or is that a mistake in the typing of "picker.onDidTriggerItemButton()"?
There was a problem hiding this comment.
Hi @tsmaeder! No, the item passed to the button cannot be a separator. The separator only has a label and no buttons. I restricted the type in the interface for this method. Ideally, we would have a dedicated type for a separator picker, that does not have this method at all, but I think that refactoring is out of scope for this PR.
AlexandraBuzila
force-pushed
the
fix/configure-tasks
branch
from
ffa8af6
to
db5f7e0
Compare
This comment was marked as spam.
This comment was marked as spam.
The gear icon in the task quick pick should open the task configuration. Fixes eclipse-theia#13086 Contributed on behalf of STMicroelectronics Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
AlexandraBuzila
force-pushed
the
fix/configure-tasks
branch
from
db5f7e0
to
9b48eb8
Compare
What it does
The gear icon in the task quick pick should open the task configuration.
Fixes #13086
Contributed on behalf of STMicroelectronics
How to test
tasks.jsonconfiguration file should openOr:
npmtasks.jsonconfiguration file should openReview checklist
Reminder for reviewers