Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: configure tasks from open task quick pick #13367

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: configure tasks from open task quick pick #13367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/common/quick-pick-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export interface QuickPick<T extends QuickPickItemOrSeparator> extends QuickInpu
readonly onDidAccept: Event<{ inBackground: boolean } | undefined>;
readonly onDidChangeValue: Event<string>;
readonly onDidTriggerButton: Event<QuickInputButton>;
readonly onDidTriggerItemButton: Event<QuickPickItemButtonEvent<T>>;
readonly onDidTriggerItemButton: Event<QuickPickItemButtonEvent<QuickPickItem>>;
readonly onDidChangeActive: Event<T[]>;
readonly onDidChangeSelection: Event<T[]>;
}
Expand Down
6 changes: 5 additions & 1 deletion packages/task/src/browser/quick-open-task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ export class QuickOpenTask implements QuickAccessProvider {
picker.matchOnDescription = true;
picker.ignoreFocusOut = false;
picker.items = this.items;
picker.onDidTriggerItemButton(({ item }) => this.onDidTriggerGearIcon(item));

const firstLevelTask = await this.doPickerFirstLevel(picker);

Expand Down Expand Up @@ -225,7 +226,10 @@ export class QuickOpenTask implements QuickAccessProvider {
execute: () => this.showMultiLevelQuickPick(true)
}));

this.quickInputService?.showQuickPick(providedTasksItems, { placeholder: CHOOSE_TASK });
this.quickInputService?.showQuickPick(providedTasksItems, {
placeholder: CHOOSE_TASK,
onDidTriggerItemButton: ({ item }) => this.onDidTriggerGearIcon(item)
});
}

attach(): void {
Expand Down
Loading