fix: configure tasks from open task quick pick (#13367)

The gear icon in the task quick pick should open the task configuration. Fixes #13086 Contributed on behalf of STMicroelectronics Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
eclipse-theia · Feb 13, 2024 · 84a54f4 · 84a54f4
1 parent ef486bd
commit 84a54f4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/core/src/common/quick-pick-service.ts b/packages/core/src/common/quick-pick-service.ts
@@ -191,7 +191,7 @@ export interface QuickPick<T extends QuickPickItemOrSeparator> extends QuickInpu
     readonly onDidAccept: Event<{ inBackground: boolean } | undefined>;
     readonly onDidChangeValue: Event<string>;
     readonly onDidTriggerButton: Event<QuickInputButton>;
-    readonly onDidTriggerItemButton: Event<QuickPickItemButtonEvent<T>>;
+    readonly onDidTriggerItemButton: Event<QuickPickItemButtonEvent<QuickPickItem>>;
     readonly onDidChangeActive: Event<T[]>;
     readonly onDidChangeSelection: Event<T[]>;
 }

diff --git a/packages/task/src/browser/quick-open-task.ts b/packages/task/src/browser/quick-open-task.ts
@@ -182,6 +182,7 @@ export class QuickOpenTask implements QuickAccessProvider {
         picker.matchOnDescription = true;
         picker.ignoreFocusOut = false;
         picker.items = this.items;
+        picker.onDidTriggerItemButton(({ item }) => this.onDidTriggerGearIcon(item));
 
         const firstLevelTask = await this.doPickerFirstLevel(picker);
 
@@ -225,7 +226,10 @@ export class QuickOpenTask implements QuickAccessProvider {
             execute: () => this.showMultiLevelQuickPick(true)
         }));
 
-        this.quickInputService?.showQuickPick(providedTasksItems, { placeholder: CHOOSE_TASK });
+        this.quickInputService?.showQuickPick(providedTasksItems, {
+            placeholder: CHOOSE_TASK,
+            onDidTriggerItemButton: ({ item }) => this.onDidTriggerGearIcon(item)
+        });
     }
 
     attach(): void {