repo: update bundled builtins #10049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Sep 6, 2021
There was a problem hiding this comment.
The npm extension does not seem to be compatible anymore:
root ERROR Failed to fetch children for 'npm' TypeError: Cannot read property 'onCancellationRequested' of undefined
at v.getTsConfigsInWorkspace (/workspace/theia/plugins/vscode.typescript-language-features/extension/dist/extension.js:45:69642)
at v.getAllTsConfigs (/workspace/theia/plugins/vscode.typescript-language-features/extension/dist/extension.js:45:68703)
at v.provideTasks (/workspace/theia/plugins/vscode.typescript-language-features/extension/dist/extension.js:45:68068)
at TaskProviderAdapter.provideTasks (/workspace/theia/packages/plugin-ext/lib/plugin/tasks/task-provider.js:25:46)
at TasksExtImpl.$provideTasks (/workspace/theia/packages/plugin-ext/lib/plugin/tasks/tasks.js:138:28)
at RPCProtocolImpl.doInvokeHandler (/workspace/theia/packages/plugin-ext/lib/common/rpc-protocol.js:232:23)
at RPCProtocolImpl.invokeHandler (/workspace/theia/packages/plugin-ext/lib/common/rpc-protocol.js:217:41)
at RPCProtocolImpl.receiveRequest (/workspace/theia/packages/plugin-ext/lib/common/rpc-protocol.js:181:33)
at RPCProtocolImpl.receiveOneMessage (/workspace/theia/packages/plugin-ext/lib/common/rpc-protocol.js:145:26)
at /workspace/theia/packages/plugin-ext/lib/common/rpc-protocol.js:69:48
The npm view does not get populated anymore, although other features, like debugging build scripts still work correctly.
Right, it’s the known issue I noticed during testing and added initially in the pull-request description. |
1 task
|
We have the option to pin misbehaving built-in extensions to slightly older versions, while we work to resolve the issues. |
vince-fugnitto
force-pushed
the
vf/vscode-builtins
branch
2 times, most recently
from
9b59c15 to
6b8257b
Compare
msujew
approved these changes
Sep 9, 2021
vince-fugnitto
force-pushed
the
vf/vscode-builtins
branch
from
6b8257b to
6268f9b
Compare
vince-fugnitto
force-pushed
the
vf/vscode-builtins
branch
2 times, most recently
from
250a049 to
2a27cc0
Compare
|
@vince-fugnitto Can this be merged? |
No, the api-tests are failing with the newer builtins (ex: |
vince-fugnitto
force-pushed
the
vf/vscode-builtins
branch
from
2a27cc0 to
cc07bfb
Compare
The commit updates the list of `builtin` plugins included with the app (bundled). The changes make use of the extension-pack (which will get resolved to the latest api version), and the list of excluded plugin ids which should not be included. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/vscode-builtins
branch
from
cc07bfb to
994279a
Compare
colin-grant-work
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9985.
The pull-request updates the list of builtins (bundled plugins) which are used in the repository for test purposes (ultimately the bundled plugins used by both the browser and electron examples). It is important to update the builtins following a default api bump (#9959) so we can identify issues more easily and work towards increased api compatibility.
The update includes the use of the builtins-extension-pack (which can be resolved at builtime to the latest supported version based on the api), and the use of an exclude list (to exclude the list of plugins we do not want as part of the application).
Known Issues:
typescript-language-featureson startup.How to test
yarn download:plugins- the pack should be installed and valid plugins should be resolved.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com