Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: align provideTasks with vscode #10061

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #8662.

The pull-request updates $provideTasks (ext-side) with the expectations of vscode and uses the CancellationToken.None when calling provideTasks from the task provider adapter.

How to test

  1. update vscode.typescript-language-features plugin to 1.50.0:
  2. start the application with a typescript project (ex: theia).
  3. open the npm scripts view in the explorer, the view should be populated.

Review checklist

Reminder for reviewers

Additional Information

Prerequisite for #10049.

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The commit updates the `provideTasks` (ext side) to omit the
cancellation token which is not present in vscode, and instead pass it
when directly calling the method from the task provider adpater.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added tasks issues related to the task system plug-in system issues related to the plug-in system labels Sep 7, 2021
@vince-fugnitto vince-fugnitto self-assigned this Sep 7, 2021
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm "Run Task..." works with the 1.50.0-level built-ins. In the long run, we should think about being able to really cancel the call, but let's cross that bridge when we get to it.

@vince-fugnitto vince-fugnitto merged commit ed82493 into master Sep 8, 2021
@vince-fugnitto vince-fugnitto deleted the vf/provide-tasks branch September 8, 2021 15:33
@github-actions github-actions bot added this to the 1.18.0 milestone Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TaskProvider.provideTask() gets no CancellationToken
2 participants