Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vscode builtins extension pack in example applications #10618

Closed
marcdumais-work opened this issue Jan 11, 2022 · 2 comments
Closed

Use vscode builtins extension pack in example applications #10618

marcdumais-work opened this issue Jan 11, 2022 · 2 comments
Assignees

Comments

@marcdumais-work
Copy link
Contributor

Use the vscode built-ins pack in example apps

Feature Description:

Theia now supports using vscode extensions packs, and the vscode built-in extensions we publish on open-vsx, have such a pack. We could easily replace the current vscode built-ins with such a pack.

example: https://github.com/eclipse-theia/theia-blueprint/blob/master/applications/electron/package.json#L121-L122

We may need to exclude a couple of built-ins, like so: https://github.com/eclipse-theia/theia-blueprint/blob/master/applications/electron/package.json#L129-L132

@marcdumais-work marcdumais-work self-assigned this Jan 11, 2022
@vince-fugnitto
Copy link
Member

@marcdumais-work just to mention I have the following pull-request #10049 but didn't get around to fixing the issues as to why the api-tests would fail for typescript.

@marcdumais-work marcdumais-work added hackathon issues reserved for hackatons and removed hackathon issues reserved for hackatons labels Jan 11, 2022
@marcdumais-work
Copy link
Contributor Author

Duplicate of #9985

@marcdumais-work marcdumais-work marked this as a duplicate of #9985 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants