New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute a proper Initial size for diagram elements #285

Closed

1 task done

mbats opened this issue Feb 2, 2021 · 0 comments · Fixed by #388

Closed

1 task done

Compute a proper Initial size for diagram elements #285

mbats opened this issue Feb 2, 2021 · 0 comments · Fixed by #388

Labels

difficulty: medium type: enhancement

Milestone

Member

mbats commented Feb 2, 2021

I have checked that this feature has not yet been suggested by someone else.

Expected behavior

Today, the incremental layout computes the node size according to a default size or the size of the associated image if exists.
The purpose is to take into account the size defined in the VSM.
The size of the contained elements must be also used.

Cuttings backs

Potential side effects

Describe alternatives you've considered

mbats mentioned this issue

Improve positions and sizes of added / moved elements #233

Closed

4 tasks

florianbarbin added a commit that referenced this issue


          [285] Compute element initial size by using the VSM information

6c8a78d

Bug: #285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

sbegaudeau added type: enhancement difficulty: medium area: layout labels

florianbarbin pushed a commit to wpiers/sirius-components that referenced this issue


          [285][287] Refactor rendering for incremental layout

85afd57

Bug: eclipse-sirius#285
Bug: eclipse-sirius#287
Signed-off-by: William Piers <william.piers@obeo.fr>
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin pushed a commit to wpiers/sirius-components that referenced this issue


          [285][287] Refactor rendering for incremental layout

9427bd4

Bug: eclipse-sirius#285
Bug: eclipse-sirius#287
Signed-off-by: William Piers <william.piers@obeo.fr>
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285][287] Refactor changes to squash with previous commit

5813dcf

Bug: eclipse-sirius#285
Bug: eclipse-sirius#287
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285][287] Refactor changes to squash with previous commit

2149c5c

Bug: eclipse-sirius#285
Bug: eclipse-sirius#287
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin pushed a commit to wpiers/sirius-components that referenced this issue


          [285][287] Refactor rendering for incremental layout

026ca2d

Bug: eclipse-sirius#285
Bug: eclipse-sirius#287
Signed-off-by: William Piers <william.piers@obeo.fr>
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285][287] Refactor changes to squash with previous commit

745eb7e

Bug: eclipse-sirius#285
Bug: eclipse-sirius#287
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285][287] Refactor changes to squash with previous commit

e323079

Bug: eclipse-sirius#285
Bug: eclipse-sirius#287
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285] Compute element initial size by using the VSM information

c4eb3e8

Bug: eclipse-sirius#285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285] Compute element initial size by using the VSM information

9961d50

Bug: eclipse-sirius#285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285] Compute element initial size by using the VSM information

aec1baa

Bug: eclipse-sirius#285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin mentioned this issue

Incremental layout refactoring #361

Merged

17 tasks

florianbarbin pushed a commit to wpiers/sirius-components that referenced this issue


          [285][287] Refactor rendering for incremental layout

fbc016e

Bug: eclipse-sirius#285
Bug: eclipse-sirius#287
Signed-off-by: William Piers <william.piers@obeo.fr>
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285] Compute element initial size by using the VSM information

d4ea022

Bug: eclipse-sirius#285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin pushed a commit to wpiers/sirius-components that referenced this issue


          [285][287] Refactor rendering for incremental layout

af5d430

Bug: eclipse-sirius#285
Bug: eclipse-sirius#287
Signed-off-by: William Piers <william.piers@obeo.fr>
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285] Compute element initial size by using the VSM information

d6dd034

Bug: eclipse-sirius#285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin pushed a commit to wpiers/sirius-components that referenced this issue


          [285][287] Refactor rendering for incremental layout

c92184d

Bug: eclipse-sirius#285
Bug: eclipse-sirius#287
Signed-off-by: William Piers <william.piers@obeo.fr>
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285] Compute element initial size by using the VSM information

4f71b6e

Bug: eclipse-sirius#285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285] Compute element initial size by using the VSM information

1d755d5

Bug: eclipse-sirius#285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit to wpiers/sirius-components that referenced this issue


          [285] Compute element initial size by using the VSM information

5c81cac

Bug: eclipse-sirius#285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

sbegaudeau changed the title ~~Initialize container size~~ Compute a proper Initial size for diagram elements

sbegaudeau added this to the 0.3.0 milestone

sbegaudeau pushed a commit that referenced this issue


          [285] Compute element initial size by using the VSM information

26a8b91

Bug: #285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

florianbarbin added a commit that referenced this issue


          [285] Compute element initial size by using the VSM information

6b5783a

Bug: #285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

pcdavid linked a pull request

that will close this issue

Add support for resizing diagram elements #388

Merged

17 tasks

sbegaudeau pushed a commit that referenced this issue


          [285] Compute element initial size by using the VSM information

d61a87d

Bug: #285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

sbegaudeau added a commit that referenced this issue


          [285] Restore the ImageSizeProvider as a proper Spring service

1aa56a0

This will improve the performance of the server with a single instance
of the cache used to compute image sizes. On top of that, said cache is
now properly disposed once again.

Bug: #285
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>

sbegaudeau added a commit that referenced this issue


          [285] Use Spring dependency injection in the compatibility layer

850cefd

Bug: #285
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>

sbegaudeau closed this as completed in #388

sbegaudeau pushed a commit that referenced this issue


          [285] Compute element initial size by using the VSM information

c1a6b33

Bug: #285
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

sbegaudeau added a commit that referenced this issue


          [285] Restore the ImageSizeProvider as a proper Spring service

d4f1d3d

This will improve the performance of the server with a single instance
of the cache used to compute image sizes. On top of that, said cache is
now properly disposed once again.

Bug: #285
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>

sbegaudeau added a commit that referenced this issue


          [285] Use Spring dependency injection in the compatibility layer

a30afb8

Bug: #285
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment