Incremental layout refactoring #361

florianbarbin · 2021-03-02T15:04:48Z

Type of this PR

Issue(s)

Issues #285 #286 #287
...

What does this PR do?

...

Screenshot/screencast of this PR

...

Potential side effects

...

How to test this PR?

Frontend Unit tests
Backend Unit tests
Cypress : please specify
Manual Test : please specify

Checklist

I have read CONTRIBUTING carefully.
I have signed the Contributor License Agreement.
All my commits are signed-off (-s) with my mail address of my Eclipse Account.
I have covered my changes by unit tests or integration tests or manual tests.
All tests pass.
I have updated the documentation accordingly
New React components are availables in storybook

...rams-layout-api/src/main/java/org/eclipse/sirius/web/diagrams/layout/api/ILayoutService.java

sbegaudeau · 2021-03-08T16:41:14Z

...ius-web-diagrams/src/main/java/org/eclipse/sirius/web/diagrams/components/NodeComponent.java

        Element labelElement = new Element(LabelComponent.class, labelComponentProps);
        List<Element> nodeChildren = new ArrayList<>();
        nodeChildren.add(labelElement);
        nodeChildren.addAll(borderNodes);
        nodeChildren.addAll(childNodes);

+        Position position = optionalPreviousNode.map(Node::getPosition).orElse(Position.UNDEFINED);
+        Size size = optionalPreviousNode.map(Node::getSize).orElse(Size.UNDEFINED);


Are you sure that this will not add back the bug in which a semantic change cannot change the size of an element?

Refactored in the last commit [285]

...c/main/java/org/eclipse/sirius/web/spring/collaborative/diagrams/DiagramCreationService.java

.../sirius-web-diagrams/src/main/java/org/eclipse/sirius/web/diagrams/RectangularNodeStyle.java

...ams/src/test/java/org/eclipse/sirius/web/diagrams/renderer/DiagramRendererEdgeTestCases.java

...ams/src/test/java/org/eclipse/sirius/web/diagrams/renderer/DiagramRendererNodeTestCases.java

...s/src/test/java/org/eclipse/sirius/web/diagrams/renderer/UnsynchronizedDiagramTestCases.java

...tests/src/main/java/org/eclipse/sirius/web/diagrams/tests/TestDiagramDescriptionBuilder.java

...b-diagrams-tests/src/main/java/org/eclipse/sirius/web/diagrams/tests/TestDiagramBuilder.java

...atibility/src/main/java/org/eclipse/sirius/web/compat/diagrams/NodeMappingStyleProvider.java

...lity/src/main/java/org/eclipse/sirius/web/compat/diagrams/ContainerMappingStyleProvider.java

.../src/test/java/org/eclipse/sirius/web/compat/diagrams/NodeMappingStyleProviderTestCases.java

.../test/java/org/eclipse/sirius/web/diagrams/layout/incremental/NodeSizeProviderTestCases.java

...-layout/src/main/java/org/eclipse/sirius/web/diagrams/layout/incremental/utils/Geometry.java

...ms-layout/src/main/java/org/eclipse/sirius/web/diagrams/layout/incremental/utils/Bounds.java

...va/org/eclipse/sirius/web/diagrams/layout/incremental/IncrementalLayoutDiagramConverter.java

...a/org/eclipse/sirius/web/diagrams/layout/incremental/IncrementalLayoutedDiagramProvider.java

...src/main/java/org/eclipse/sirius/web/diagrams/layout/incremental/data/DiagramLayoutData.java

.../main/java/org/eclipse/sirius/web/diagrams/layout/incremental/provider/NodeSizeProvider.java

...rc/main/java/org/eclipse/sirius/web/diagrams/layout/incremental/updater/OverlapsUpdater.java

doc/adrs/013_improve_edge_source_and_target_anchors.adoc

sbegaudeau

See the other comments

Bug: eclipse-sirius#382 Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

Bug: eclipse-sirius#286 Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

Bug: eclipse-sirius#287 Signed-off-by: William Piers <william.piers@obeo.fr> Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

Bug: eclipse-sirius#286 Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>

Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>

sbegaudeau added pr: to review soon priority: high labels Mar 2, 2021

sbegaudeau self-assigned this Mar 2, 2021

florianbarbin force-pushed the wpi/enh/refactoring branch 2 times, most recently from d4ea022 to d6dd034 Compare March 5, 2021 09:53