Skip to content

Commit

Permalink
[285][287] Refactor rendering for incremental layout
Browse files Browse the repository at this point in the history
Bug: eclipse-sirius#285
Bug: eclipse-sirius#287
Signed-off-by: William Piers <william.piers@obeo.fr>
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
  • Loading branch information
wpiers authored and florianbarbin committed Mar 1, 2021
1 parent d1fcdc5 commit 026ca2d
Show file tree
Hide file tree
Showing 46 changed files with 1,931 additions and 1,002 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ private Element createNodeElement(UUID descriptionId) {
.style(style)
.position(Position.UNDEFINED)
.size(Size.UNDEFINED)
.absolutePosition(Position.UNDEFINED)
.children(List.of())
.build();
// @formatter:on
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ private Element createNodeElement(UUID descriptionId) {
.style(style)
.position(Position.UNDEFINED)
.size(Size.UNDEFINED)
.absolutePosition(Position.UNDEFINED)
.children(List.of())
.build();
// @formatter:on
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2019, 2020 Obeo.
* Copyright (c) 2019, 2021 Obeo and others.
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v2.0
* which accompanies this distribution, and is available at
Expand All @@ -12,7 +12,11 @@
*******************************************************************************/
package org.eclipse.sirius.web.diagrams.layout.api;

import java.util.Optional;

import org.eclipse.sirius.web.diagrams.Diagram;
import org.eclipse.sirius.web.diagrams.MoveEvent;
import org.eclipse.sirius.web.diagrams.Position;

/**
* Implementation of this interface will layout the given diagram.
Expand All @@ -21,4 +25,18 @@
*/
public interface ILayoutService {
Diagram layout(Diagram diagram);

/**
* A partial layout that layouts only impacted elements.
*
* @param diagram
* The new diagram to layout.
* @param moveEvent
* the {@link MoveEvent} that has trigger the new layout. Can be null if no event occurs.
* @param startingPosition
* the {@link Position} to use to create new graphical elements (following a tool applied on the diagram
* for instance.
* @return the new layouted diagram.
*/
Diagram incrementalLayout(Diagram diagram, Optional<MoveEvent> moveEvent, Position startingPosition);
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import java.util.Map;
import java.util.Objects;
import java.util.Optional;

import org.eclipse.elk.alg.layered.options.LayeredOptions;
import org.eclipse.elk.core.IGraphLayoutEngine;
Expand All @@ -25,8 +26,13 @@
import org.eclipse.elk.graph.ElkGraphElement;
import org.eclipse.elk.graph.ElkNode;
import org.eclipse.sirius.web.diagrams.Diagram;
import org.eclipse.sirius.web.diagrams.MoveEvent;
import org.eclipse.sirius.web.diagrams.Position;
import org.eclipse.sirius.web.diagrams.description.DiagramDescription;
import org.eclipse.sirius.web.diagrams.layout.api.ILayoutService;
import org.eclipse.sirius.web.diagrams.layout.incremental.IncrementalLayoutEngine;
import org.eclipse.sirius.web.diagrams.layout.incremental.data.DiagramLayoutData;
import org.eclipse.sirius.web.diagrams.layout.incremental.data.ILayoutData;
import org.eclipse.sirius.web.services.api.representations.IRepresentationDescriptionService;
import org.springframework.stereotype.Service;

Expand Down Expand Up @@ -79,4 +85,13 @@ public Diagram layout(Diagram diagram) {
return layoutedDiagram;
}

@Override
public Diagram incrementalLayout(Diagram newDiagram, Optional<MoveEvent> optionalMoveEvent, Position startingPosition) {
org.eclipse.sirius.web.diagrams.layout.incremental.ConvertedDiagram convertedDiagram = new org.eclipse.sirius.web.diagrams.layout.incremental.DiagramConverter().convert(newDiagram);
DiagramLayoutData diagramLayoutData = convertedDiagram.getDiagramLayoutData();
new IncrementalLayoutEngine(optionalMoveEvent, startingPosition).layout(diagramLayoutData);
Map<String, ILayoutData> id2LayoutData = convertedDiagram.getId2LayoutData();
return new org.eclipse.sirius.web.diagrams.layout.incremental.LayoutedDiagramProvider().getLayoutedDiagram(newDiagram, diagramLayoutData, id2LayoutData);
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/*******************************************************************************
* Copyright (c) 2021 THALES GLOBAL SERVICES.
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v2.0
* which accompanies this distribution, and is available at
* https://www.eclipse.org/legal/epl-2.0/
*
* SPDX-License-Identifier: EPL-2.0
*
* Contributors:
* Obeo - initial API and implementation
*******************************************************************************/
package org.eclipse.sirius.web.diagrams.layout.incremental;

import java.util.Map;
import java.util.Objects;

import org.eclipse.sirius.web.diagrams.layout.incremental.data.DiagramLayoutData;
import org.eclipse.sirius.web.diagrams.layout.incremental.data.ILayoutData;

/**
* The result of the diagram transformation with the raw layout data and a cache of the values computed during the
* transformation.
*
* @author wpiers
*/
public class ConvertedDiagram {

private final DiagramLayoutData diagramLayoutData;

private final Map<String, ILayoutData> id2LayoutData;

public ConvertedDiagram(DiagramLayoutData diagramLayoutData, Map<String, ILayoutData> id2LayoutData) {
this.diagramLayoutData = Objects.requireNonNull(diagramLayoutData);
this.id2LayoutData = Objects.requireNonNull(id2LayoutData);
}

public DiagramLayoutData getDiagramLayoutData() {
return this.diagramLayoutData;
}

public Map<String, ILayoutData> getId2LayoutData() {
return this.id2LayoutData;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,134 @@
/*******************************************************************************
* Copyright (c) 2021 Thales.
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v2.0
* which accompanies this distribution, and is available at
* https://www.eclipse.org/legal/epl-2.0/
*
* SPDX-License-Identifier: EPL-2.0
*
* Contributors:
* Obeo - initial API and implementation
*******************************************************************************/
package org.eclipse.sirius.web.diagrams.layout.incremental;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

import org.eclipse.sirius.web.diagrams.Diagram;
import org.eclipse.sirius.web.diagrams.Edge;
import org.eclipse.sirius.web.diagrams.Label;
import org.eclipse.sirius.web.diagrams.Node;
import org.eclipse.sirius.web.diagrams.TextBounds;
import org.eclipse.sirius.web.diagrams.TextBoundsProvider;
import org.eclipse.sirius.web.diagrams.layout.incremental.data.DiagramLayoutData;
import org.eclipse.sirius.web.diagrams.layout.incremental.data.EdgeLayoutData;
import org.eclipse.sirius.web.diagrams.layout.incremental.data.IContainerLayoutData;
import org.eclipse.sirius.web.diagrams.layout.incremental.data.ILayoutData;
import org.eclipse.sirius.web.diagrams.layout.incremental.data.LabelLayoutData;
import org.eclipse.sirius.web.diagrams.layout.incremental.data.NodeLayoutData;

/**
* Used to convert the diagram into layout data. During the transformation.
*
* @author wpiers
*/
public class DiagramConverter {

public ConvertedDiagram convert(Diagram diagram) {
Map<String, ILayoutData> id2LayoutData = new HashMap<>();

DiagramLayoutData layoutData = new DiagramLayoutData();
String id = diagram.getId().toString();
layoutData.setId(id);
id2LayoutData.put(id, layoutData);

layoutData.setPosition(diagram.getPosition());
layoutData.setSize(diagram.getSize());

List<NodeLayoutData> nodes = new ArrayList<>();
for (Node node : diagram.getNodes()) {
nodes.add(this.convertNode(node, layoutData, id2LayoutData));
}
layoutData.setChildrenNodes(nodes);

List<EdgeLayoutData> edges = new ArrayList<>();
for (Edge edge : diagram.getEdges()) {
edges.add(this.convertEdge(edge, layoutData, id2LayoutData));
}
layoutData.setEdges(edges);

return new ConvertedDiagram(layoutData, id2LayoutData);
}

private NodeLayoutData convertNode(Node node, IContainerLayoutData parent, Map<String, ILayoutData> id2LayoutData) {
NodeLayoutData layoutData = new NodeLayoutData();
String id = node.getId().toString();
layoutData.setId(id);
id2LayoutData.put(node.getId().toString(), layoutData);

layoutData.setParent(parent);
layoutData.setNodeType(node.getType());
layoutData.setStyle(node.getStyle());

layoutData.setPosition(node.getPosition());
layoutData.setSize(node.getSize());

List<NodeLayoutData> borderNodes = new ArrayList<>();
for (Node borderNode : node.getBorderNodes()) {
borderNodes.add(this.convertNode(borderNode, layoutData, id2LayoutData));
}
layoutData.setBorderNodes(borderNodes);

List<NodeLayoutData> childNodes = new ArrayList<>();
for (Node childNode : node.getChildNodes()) {
childNodes.add(this.convertNode(childNode, layoutData, id2LayoutData));
}
layoutData.setChildrenNodes(childNodes);

LabelLayoutData labelLayoutData = this.convertLabel(node.getLabel(), id2LayoutData);
layoutData.setLabel(labelLayoutData);

return layoutData;
}

private EdgeLayoutData convertEdge(Edge edge, DiagramLayoutData diagramLayoutData, Map<String, ILayoutData> id2LayoutData) {
EdgeLayoutData layoutData = new EdgeLayoutData();
String id = edge.getId().toString();
layoutData.setId(id);
id2LayoutData.put(edge.getId().toString(), layoutData);

if (edge.getBeginLabel() != null) {
layoutData.setBeginLabel(this.convertLabel(edge.getBeginLabel(), id2LayoutData));
}
if (edge.getCenterLabel() != null) {
layoutData.setCenterLabel(this.convertLabel(edge.getCenterLabel(), id2LayoutData));
}
if (edge.getEndLabel() != null) {
layoutData.setEndLabel(this.convertLabel(edge.getEndLabel(), id2LayoutData));
}

layoutData.setRoutingPoints(edge.getRoutingPoints());
layoutData.setSource((NodeLayoutData) id2LayoutData.get(edge.getSourceId().toString()));
layoutData.setTarget((NodeLayoutData) id2LayoutData.get(edge.getTargetId().toString()));

return layoutData;
}

private LabelLayoutData convertLabel(Label label, Map<String, ILayoutData> id2LayoutData) {
LabelLayoutData layoutData = new LabelLayoutData();
String id = label.getId().toString();
layoutData.setId(id);
id2LayoutData.put(label.getId().toString(), layoutData);

layoutData.setPosition(label.getPosition());

TextBounds textBounds = new TextBoundsProvider().computeBounds(label.getStyle(), label.getText());
layoutData.setTextBounds(textBounds);

return layoutData;
}

}
Loading

0 comments on commit 026ca2d

Please sign in to comment.