-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stubs for Constants API (jep334) #4030
Conversation
44f44e6
to
452b74a
Compare
d233cda
to
a8e4f3a
Compare
update copyrights |
Note System.Logger.Level implements Constable |
and Thread.State implements Constable |
and StackWalker.Option implements Constable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@theresa-m Can you rebase and squash these two commits? |
Note these changes are required, either here or in another PR. System.Logger.Level implements Constable Thread.State implements Constable StackWalker.Option implements Constable |
working on that. I'll add the extra extends here as well |
actually I thought that because Enum already implements Constable that it wasn't necessary to add |
a8e4f3a
to
3e9f948
Compare
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
3e9f948
to
b229be5
Compare
Sounds good. I missed that because I was just looking at changes in the classes OpenJ9 implements. |
Jenkins test sanity zlinux jdk11 |
Once the jdk11 sanity build passes, I'll merge this. |
This change adds the remaining method stubs for jep334 that were not directly needed to compile Java12 and adjusts interface implementation dependencies for Constable classes.
Java 12 depends on #3980 to compile (also see #4195)
Signed-off-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com