Methods and tests for jep334 MethodType #4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
force-pushed
the
jep334_methodtype
branch
from
dc052f0 to
741dbcf
Compare
9 tasks
theresa-m
force-pushed
the
jep334_methodtype
branch
from
741dbcf to
3266d3d
Compare
theresa-m
force-pushed
the
jep334_methodtype
branch
from
3266d3d to
0e7f24a
Compare
DanHeidinga
reviewed
Feb 14, 2019
jcl/src/java.base/share/classes/java/lang/invoke/MethodType.java
Outdated
Show resolved
Hide resolved
test/functional/Java12andUp/src/org/openj9/test/java_lang_invoke/Test_MethodType.java
Outdated
Show resolved
Hide resolved
test/functional/Java12andUp/src/org/openj9/test/java_lang_invoke/Test_MethodType.java
Outdated
Show resolved
Hide resolved
test/functional/Java12andUp/src/org/openj9/test/java_lang_invoke/Test_MethodType.java
Show resolved
Hide resolved
DanHeidinga
reviewed
Feb 14, 2019
test/functional/Java12andUp/src/org/openj9/test/java_lang_invoke/Test_MethodType.java
Outdated
Show resolved
Hide resolved
theresa-m
force-pushed
the
jep334_methodtype
branch
2 times, most recently
from
24d203f to
b9b883f
Compare
|
I've updated my commits from the review comments. |
|
@theresa-m Can you rebase this so it'll pick up with jvm interface fix? Then I can PR test it |
DanHeidinga
approved these changes
Feb 21, 2019
|
the MethodType.describeConstable implementation is dependent on ClassDesc which hasn't been merged yet. |
|
@theresa-m Can you rebase and resolve the conflict? |
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
- describeConstable - descriptorString Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
theresa-m
force-pushed
the
jep334_methodtype
branch
from
b9b883f to
8ce58a6
Compare
|
@DanHeidinga its ready for a pr build now |
|
Jenkins test sanity plinux jdk12 |
|
Only the known |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on (see #4195):
Signed-off-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com