Jep334 VarHandle and VarHandleDesc #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
theresa-m
force-pushed
the
jep334_varhandle
branch
from
a493355 to
6474281
Compare
theresa-m
force-pushed
the
jep334_varhandle
branch
from
6474281 to
3105ca5
Compare
DanHeidinga
reviewed
Feb 14, 2019
jcl/src/java.base/share/classes/com/ibm/oti/util/ExternalMessages-MasterIndex.properties
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/java/lang/invoke/ArrayVarHandle.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/java/lang/invoke/InstanceFieldVarHandle.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/java/lang/invoke/VarHandle.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/java/lang/invoke/VarHandle.java
Outdated
Show resolved
Hide resolved
test/functional/Java12andUp/src/org/openj9/test/java_lang_invoke/Test_VarHandle.java
Outdated
Show resolved
Hide resolved
test/functional/Java12andUp/src/org/openj9/test/java_lang_invoke/Test_VarHandle.java
Outdated
Show resolved
Hide resolved
test/functional/Java12andUp/src/org/openj9/test/java_lang_invoke/helpers/Helper.java
Outdated
Show resolved
Hide resolved
theresa-m
force-pushed
the
jep334_varhandle
branch
3 times, most recently
from
48c6910 to
1c25333
Compare
|
ready for another review |
theresa-m
force-pushed
the
jep334_varhandle
branch
from
1c25333 to
1985b73
Compare
DanHeidinga
reviewed
Feb 22, 2019
| * - hashCode | ||
| * - toString | ||
| */ | ||
| public class Test_VarHandle { |
There was a problem hiding this comment.
This file is using spaces instead tabs. Can you convert to tabs to be consistent with the other java code?
| * - toString | ||
| * - varType: covered in ofArray / ofField / ofStaticField tests | ||
| */ | ||
| public class Test_VarHandleDesc { |
There was a problem hiding this comment.
tabs vs spaces here as well
theresa-m
force-pushed
the
jep334_varhandle
branch
from
1985b73 to
644743f
Compare
|
I've fixed the formatting issue |
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
DanHeidinga
force-pushed
the
jep334_varhandle
branch
from
644743f to
1a1477f
Compare
|
Rebased to address the conflicts |
|
Jenkins test sanity zlinux jdk12 |
|
thanks @DanHeidinga ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on (see #4195):
Methods:
VarHandleDesc constructor
VarHandleDesc.ofArray
VarHandleDesc.ofField
VarHandleDesc.ofStaticField
VarHandleDesc.resolveConstantDesc
VarHandleDesc.toString
VarHandleDesc.varType
VarHandle.describeConstable
VarHandle.equals
VarHandle.hashCode
VarHandle.toString