Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a dockerfile for OpenJDK 10 builds and update v8 & v9 dockerfiles #1497

Closed
SueChaplain opened this issue Mar 21, 2018 · 9 comments
Closed

Comments

@SueChaplain
Copy link
Contributor

/buildenv/docker/* dockerfiles for Java 8 & 9 pull OpenJDK builds from Ubuntu as the bootjdk images. These should be replaced with Adopt builds.

We also need a dockerfile for Java 10 which we can link to from the OpenJ9 website build page:
https://www.eclipse.org/openj9/oj9_build.html

@DanHeidinga
Copy link
Member

@babsingh Can you create the JDK 10 docker file?

The Extensions repo is at https://github.com/ibmruntimes/openj9-openjdk-jdk10 and should have content soon.

@DanHeidinga
Copy link
Member

For the bootjdk, we should try to use an AdoptOpenJDK JDK9 build. Adopt has an API that can be used to download specific binaries https://api.adoptopenjdk.net/README

Let's get the 10 dockerfile asap and then look at updating the 8/9 ones

@babsingh
Copy link
Contributor

Started dockerfile work for OpenJDK 10 builds here: #1514

@babsingh
Copy link
Contributor

Started work to update JDK9 (buildenv/docker/jdk9/*) Dockerfile(s) here: #1541

@babsingh
Copy link
Contributor

babsingh commented Mar 26, 2018

For JDK 8 DockerFiles, we won't be able to use Adopt builds for the boot jdk since AdoptOpenJDK doesn't support OpenJDK7 builds.

An exception was made for JDK8 s390x DockerFile to use AdoptOpenJDK OpenJ9 OpenJDK8 build as the boot jdk: #1526.

Started work to update JDK8 s390x DockerFile here: #1545.

@babsingh
Copy link
Contributor

babsingh commented Apr 11, 2018

@SueChaplain @DanHeidinga All changes have been delivered. This issue can be closed.

Update:

  1. OpenJDK 10 DockerFile(s) have been added (Add docker files for OpenJDK 10 #1514; merged).
  2. OpenJDK 9 DockerFiles(s) have been updated to use AdoptOpenJDK OpenJ9 JDK8 builds as the boot JDK (Update buildenv/docker/jdk9/* Dockerfile(s) #1541; merged).
  3. Only OpenJDK 8 s390 was updated to use AdoptOpenJDK OpenJ9 JDK8 build due to a performance issue (Update s390 docker image for JDK8 to use Adopt-OpenJ9 #1545; merged). Other OpenJDK 8 DockerFile(s) need to follow the convention of using (N -1) JDK7 builds as the boot JDK. AdoptOpenJDK doesn't support JDK7 builds so we can't use AdoptOpenJDK builds for the remaining OpenJDK 8 DockerFile(s).

@DanHeidinga
Copy link
Member

Thanks @babsingh

We also need a dockerfile for Java 10 which we can link to from the OpenJ9 website build page:
https://www.eclipse.org/openj9/oj9_build.html

Have you opened a PR for the update to the website as well?

@babsingh
Copy link
Contributor

babsingh commented Apr 11, 2018

Created a pull request for updating oj9_build.html - eclipse-openj9/openj9-website#73
Created a pull request for adding Build_Instructions_V10.md and its dependencies: #1665

babsingh added a commit to babsingh/openj9 that referenced this issue Apr 11, 2018
Build_Instructions_V10.md: Includes full set of build instructions for
JDK 10. It has been copied from Build_Instructions_V9.md and updated to
reflect JDK 10 instructions. It will need to be revised by the original
author. It has been added since
https://www.eclipse.org/openj9/oj9_build.html will point to these
instructions via a web-link.

buildenv/aix/jdk10/yum_install_aix-ppc64.txt: Includes a list of
packages needed to build OpenJDK 10 on AIX PPC. Currently, it is copied
from buildenv/aix/jdk9/yum_install_aix-ppc64.txt. Someone with access to
a personal AIX machine would need to test this file using yum and update
it accordingly. It has been added since Build_Instructions_V10.md points
to buildenv/aix/jdk10/yum_install_aix-ppc64.txt via a file path link.

openj9 issue: eclipse-openj9#1497
openj9-website pull request:
eclipse-openj9/openj9-website#73

[skip ci]

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Copy link
Contributor

babsingh commented May 9, 2018

@DanHeidinga all changes are compete for this issue. the eclipse openj9 build page has been updated to show Java 10 instructions: https://www.eclipse.org/openj9/oj9_build.html. so, this issue can be closed.

@pshipton pshipton closed this as completed May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants