-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buildenv/docker/jdk9/* Dockerfile(s) #1541
Update buildenv/docker/jdk9/* Dockerfile(s) #1541
Conversation
For aarch64_CC and armhf_CC DockerFile(s), download links for the following libraries were updated: libcups2-dev_2.2.1-8 and libcupsimage2-dev_2.2.1-8. Old download links don't work anymore. [skip ci] Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
3cd5b40
to
fe2fc95
Compare
fe2fc95
to
7e27233
Compare
@JamesKingdon please review the arm changes. |
7e27233
to
3805dc3
Compare
@babsingh Why were the changes to cups needed? |
@JamesKingdon old download links don't exist. so, i had to replace them with working links. |
ab69bb2
to
06235f0
Compare
Ah, right you are - many thanks for fixing! |
Testing was done successfully for
|
AdoptOpenJDK OpenJ9 build is used as the boot jdk: 1) arm-linux-aarch64 (x64_linux): https://api.adoptopenjdk.net/openjdk8-openj9/releases/x64_linux/latest/binary 2) arm-linux-gnueabihf (x64_linux): https://api.adoptopenjdk.net/openjdk8-openj9/releases/x64_linux/latest/binary 3) ppc64le (ppc64le_linux): https://api.adoptopenjdk.net/openjdk8-openj9/releases/ppc64le_linux/latest/binary 4) s390x (s390x_linux): https://api.adoptopenjdk.net/openjdk8-openj9/releases/s390x_linux/latest/binary 5) x86_64 (x64_linux): https://api.adoptopenjdk.net/openjdk8-openj9/releases/x64_linux/latest/binary For s390x and ppc64le, the base image is changed to "ubuntu:16.04". [skip ci] Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
06235f0
to
2ff0027
Compare
@keithc-ca can you review these changes as well? similar to #1514, testing is pending for |
Skipping PR testing; these files should not affect builds. |
@babsingh Can you please squash before I merge? |
@keithc-ca the two commits cover two distinct issues. do we squash if each commit covers a different issue? |
Ok, we don't need to squash. |
[skip ci]
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com