Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildenv/docker/jdk9/* Dockerfile(s) #1541

Merged
merged 2 commits into from
Apr 8, 2018

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented Mar 26, 2018

  • Use AdoptOpenJDK OpenJ9 build as the boot jdk for JDK9 DockerFile(s).
AdoptOpenJDK OpenJ9 build is used as the boot jdk:
1) arm-linux-aarch64 (x64_linux):
https://api.adoptopenjdk.net/openjdk8-openj9/releases/x64_linux/latest/binary
2) arm-linux-gnueabihf (x64_linux):
https://api.adoptopenjdk.net/openjdk8-openj9/releases/x64_linux/latest/binary
3) ppc64le (ppc64le_linux):
https://api.adoptopenjdk.net/openjdk8-openj9/releases/ppc64le_linux/latest/binary
4) s390x (s390x_linux):
https://api.adoptopenjdk.net/openjdk8-openj9/releases/s390x_linux/latest/binary
5) x86_64 (x64_linux):
https://api.adoptopenjdk.net/openjdk8-openj9/releases/x64_linux/latest/binary

For s390x and ppc64le, the base image is changed to "ubuntu:16.04".
  • Update download links to libcups2-dev and libcupsimage2-dev libraries in JDK9 DockerFile(s).
For aarch64_CC and armhf_CC DockerFile(s), download links for the
following libraries were updated: libcups2-dev_2.2.1-8 and
libcupsimage2-dev_2.2.1-8. Old download links don't work anymore.

[skip ci]

Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

For aarch64_CC and armhf_CC DockerFile(s), download links for the
following libraries were updated: libcups2-dev_2.2.1-8 and
libcupsimage2-dev_2.2.1-8. Old download links don't work anymore.

[skip ci]

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@pshipton
Copy link
Member

@JamesKingdon please review the arm changes.

@JamesKingdon
Copy link
Contributor

@babsingh Why were the changes to cups needed?

@babsingh
Copy link
Contributor Author

@JamesKingdon old download links don't exist. so, i had to replace them with working links.

@babsingh babsingh force-pushed the dockerfiles_update_jdk9 branch 2 times, most recently from ab69bb2 to 06235f0 Compare March 27, 2018 16:01
@JamesKingdon
Copy link
Contributor

Ah, right you are - many thanks for fixing!

@babsingh
Copy link
Contributor Author

babsingh commented Apr 2, 2018

Testing was done successfully for x86 and arm platforms using the below instructions. Based upon Joe's s390 testing for #1545 and #1514, these changes should work fine on s390. Testing can't be done on ppcle since no machines are available. It will take some time to get access to Ubuntu ppcle machines with Docker installed. When ppcle machines become available, fixes will be pushed in a new pull request if testing fails.

    Build docker: docker build -f buildenv/docker/jdk9/${platform}/ubuntu16/Dockerfile -t=openj9 .
    Run docker: docker run -i -t openj9:latest /bin/bash
    Test boot jdk: java -version
    Build Java 9
        git clone https://github.com/ibmruntimes/openj9-openjdk-jdk9.git
        cd openj9-openjdk-jdk9
        bash ./get_source.sh
        bash ./configure --with-freemarker-jar=/root/freemarker.jar
        make images
    Test Java 9: build/${platform}/images/jdk/bin/java -version

AdoptOpenJDK OpenJ9 build is used as the boot jdk:
1) arm-linux-aarch64 (x64_linux):
https://api.adoptopenjdk.net/openjdk8-openj9/releases/x64_linux/latest/binary
2) arm-linux-gnueabihf (x64_linux):
https://api.adoptopenjdk.net/openjdk8-openj9/releases/x64_linux/latest/binary
3) ppc64le (ppc64le_linux):
https://api.adoptopenjdk.net/openjdk8-openj9/releases/ppc64le_linux/latest/binary
4) s390x (s390x_linux):
https://api.adoptopenjdk.net/openjdk8-openj9/releases/s390x_linux/latest/binary
5) x86_64 (x64_linux):
https://api.adoptopenjdk.net/openjdk8-openj9/releases/x64_linux/latest/binary

For s390x and ppc64le, the base image is changed to "ubuntu:16.04".

[skip ci]

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh babsingh force-pushed the dockerfiles_update_jdk9 branch from 06235f0 to 2ff0027 Compare April 5, 2018 22:35
@babsingh
Copy link
Contributor Author

babsingh commented Apr 5, 2018

@keithc-ca can you review these changes as well? similar to #1514, testing is pending for ppcle. can you please test the DockerFile on ppcle? Thanks.

@keithc-ca keithc-ca self-assigned this Apr 6, 2018
@keithc-ca
Copy link
Contributor

Skipping PR testing; these files should not affect builds.

@keithc-ca
Copy link
Contributor

@babsingh Can you please squash before I merge?

@babsingh
Copy link
Contributor Author

babsingh commented Apr 8, 2018

@keithc-ca the two commits cover two distinct issues. do we squash if each commit covers a different issue?

@keithc-ca
Copy link
Contributor

Ok, we don't need to squash.

@keithc-ca keithc-ca merged commit 39c5724 into eclipse-openj9:master Apr 8, 2018
@babsingh babsingh deleted the dockerfiles_update_jdk9 branch August 17, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants