Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update oj9_build.html to include JDK10 instructions #73

Closed
wants to merge 1 commit into from
Closed

Update oj9_build.html to include JDK10 instructions #73

wants to merge 1 commit into from

Conversation

babsingh
Copy link

@babsingh babsingh commented Apr 11, 2018 •
edited by pshipton
Loading

Fixes eclipse-openj9/openj9#1497

Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

@babsingh
Copy link
Author

babsingh commented Apr 11, 2018 •
edited
Loading

@SueChaplain @DanHeidinga this is related to eclipse-openj9/openj9#1497

@babsingh babsingh mentioned this pull request Apr 11, 2018
Closed
@babsingh
Update oj9_build.html to include JDK10 instructions
800d064 
Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh babsingh changed the title WIP: Update oj9_build.html to include JDK10 instructions Update oj9_build.html to include JDK10 instructions Apr 11, 2018
@babsingh babsingh mentioned this pull request Apr 11, 2018
Merged
@babsingh
Copy link
Author

A web link to Build_Instructions_V10.md is added: https://github.com/eclipse/openj9/blob/master/buildenv/Build_Instructions_V10.md.

Build_Instructions_V10.md points to buildenv/aix/jdk10/yum_install_aix-ppc64.txt.

Build_Instructions_V10.md and buildenv/aix/jdk10/yum_install_aix-ppc64.txt are being added to OpenJ9 repo via eclipse-openj9/openj9#1665.

babsingh added a commit to babsingh/openj9 that referenced this pull request Apr 11, 2018
@babsingh
Add build instructions for OpenJDK 10
2973ec8 
Build_Instructions_V10.md: Includes full set of build instructions for
JDK 10. It has been copied from Build_Instructions_V9.md and updated to
reflect JDK 10 instructions. It will need to be revised by the original
author. It has been added since
https://www.eclipse.org/openj9/oj9_build.html will point to these
instructions via a web-link.

buildenv/aix/jdk10/yum_install_aix-ppc64.txt: Includes a list of
packages needed to build OpenJDK 10 on AIX PPC. Currently, it is copied
from buildenv/aix/jdk9/yum_install_aix-ppc64.txt. Someone with access to
a personal AIX machine would need to test this file using yum and update
it accordingly. It has been added since Build_Instructions_V10.md points
to buildenv/aix/jdk10/yum_install_aix-ppc64.txt via a file path link.

openj9 issue: eclipse-openj9#1497
openj9-website pull request:
eclipse-openj9/openj9-website#73

[skip ci]

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@pmhayward
Copy link
Contributor

Jenkins website stage

@SueChaplain
Copy link
Contributor

@babsingh
Thanks for creating this PR. The updates you made were good, but unfortunately our javascript solution for changing build instructions per version did not like having 3 versions to deal with. Peter has worked on a new solution involving tabs, which he's more or less ready to implement. We've taken the Java 10 updates you made in this PR and re-used them. Thanks again for your input. I'll close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babsingh @pmhayward @SueChaplain