Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logstash-logback dependencies to avoid classloading issue when using logstash-logback appenders #6539

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

sunix
Copy link
Contributor

@sunix sunix commented Oct 3, 2017

What does this PR do?

Adding logstash-logback dependencies to avoid classloading issue when using logstash-logback appenders (#6537)
This PR is depends on eclipse-che/che-lib#42

What issues does this PR fix or reference?

#6537

Docs PR

eclipse-che/che-docs#297

… using logstash-logback appenders (eclipse-che#6537)

Signed-off-by: Sun Tan <sutan@redhat.com>
@sunix sunix requested a review from riuvshin as a code owner October 3, 2017 08:26
@sunix sunix self-assigned this Oct 3, 2017
@sunix sunix added kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development. team/osio labels Oct 3, 2017
@skabashnyuk
Copy link
Contributor

skabashnyuk commented Oct 3, 2017

+

@codenvy-ci
Copy link

Build # 3949 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3949/ to view the results.

@slemeur slemeur changed the title Adding logstash-logback dependencies to avoid classloading issue when using logstash-logback appenders (#6537) Adding logstash-logback dependencies to avoid classloading issue when using logstash-logback appenders Oct 4, 2017
@skabashnyuk
Copy link
Contributor

PR for Che6?

@sunix sunix merged commit 2c0468a into eclipse-che:master Nov 16, 2017
@benoitf benoitf added this to the 5.21.0 milestone Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants