Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

Adding logstash-logback-encoder 4.11 (che#6537) #60

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Adding logstash-logback-encoder 4.11 (che#6537) #60

merged 1 commit into from
Nov 16, 2017

Conversation

sunix
Copy link
Contributor

@sunix sunix commented Oct 3, 2017 •
edited
Loading

@sunix
Adding logstash-logback dependency (#6537)
fa2c203 
Signed-off-by: Sun Tan <sutan@redhat.com>
@sunix sunix requested a review from riuvshin as a code owner October 3, 2017 08:34
@sunix sunix mentioned this pull request Oct 3, 2017
Closed
7 tasks
riuvshin
riuvshin approved these changes Oct 3, 2017
View reviewed changes
Copy link

@riuvshin riuvshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if this does not require CQ

@sunix
Copy link
Contributor Author

sunix commented Oct 4, 2017

CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=14394

@sunix sunix changed the title https://github.com/eclipse/che/issues/6537 Adding logstash-logback-encoder 4.11 (che#6537) Oct 4, 2017
skabashnyuk
skabashnyuk approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@skabashnyuk skabashnyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunix can you make sure that logstash-logback-encoder doesn't provide additional transitive dependencies.

@sunix sunix mentioned this pull request Nov 6, 2017
Merged
@sunix
Copy link
Contributor Author

sunix commented Nov 16, 2017

CQ approved, merging

@sunix sunix merged commit 711cc9b into eclipse-che:master Nov 16, 2017
@sunix
Copy link
Contributor Author

sunix commented Nov 16, 2017 •
edited
Loading

@skabashnyuk
looks fine (just added the library as a dependency for testing mvn dependency:tree):

[INFO] --- maven-dependency-plugin:3.0.1:tree (default-cli) @ maven-depmgt-pom ---                                                            
[INFO] org.eclipse.che.depmgt:maven-depmgt-pom:pom:5.21.0-SNAPSHOT                                                                            
[INFO] \- net.logstash.logback:logstash-logback-encoder:jar:4.11:compile                                                                      
[INFO]    +- ch.qos.logback:logback-core:jar:1.2.1:compile                                                                                    
[INFO]    \- com.fasterxml.jackson.core:jackson-databind:jar:2.7.7:compile                                                                    
[INFO]       +- com.fasterxml.jackson.core:jackson-annotations:jar:2.7.7:compile                                                              
[INFO]       \- com.fasterxml.jackson.core:jackson-core:jar:2.7.7:compile

@sunix sunix mentioned this pull request Nov 16, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@riuvshin riuvshin riuvshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunix @skabashnyuk @riuvshin