Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding new Logstash logback appenders to che-server tomcat logback.xml #6537

Closed
7 tasks done
sunix opened this issue Oct 3, 2017 · 1 comment
Closed
7 tasks done
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development.

Comments

@sunix
Copy link
Contributor

sunix commented Oct 3, 2017

At the moment, it is not possible to add logstash-logback appenders to logback.xml. It would be useful to just provide a proper logback-additional-appenders.xml and nothing else

Reproduction Steps:
Adding a logback-additional-appenders.xml like

<?xml version="1.0" encoding="UTF-8"?>
<included>
    <appender name="file-json" class="ch.qos.logback.core.rolling.RollingFileAppender">
        <file>${che.logs.dir}/logs/catalina.log.json</file>
        <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
          <level>info</level>
        </filter>
        <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">
            <fileNamePattern>${che.logs.dir}/archive/%d{yyyy/MM/dd}/catalina.log.json</fileNamePattern>
            <maxHistory>${max.retention.days}</maxHistory>
        </rollingPolicy>
        <encoder class="net.logstash.logback.encoder.LogstashEncoder" />
    </appender>

    <root level="${che.logs.level:-INFO}">
        <appender-ref ref="file-json"/>
    </root>
</included>

won't work at the moment

Pull Requests

** PR for che6 **

@sunix sunix added kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development. team/osio labels Oct 3, 2017
@sunix sunix self-assigned this Oct 3, 2017
sunix added a commit to sunix/che that referenced this issue Oct 3, 2017
… using logstash-logback appenders (eclipse-che#6537)

Signed-off-by: Sun Tan <sutan@redhat.com>
sunix added a commit that referenced this issue Nov 16, 2017
… using logstash-logback appenders (#6537)

Signed-off-by: Sun Tan <sutan@redhat.com>
sunix added a commit to sunix/che that referenced this issue Nov 16, 2017
… using logstash-logback appenders (eclipse-che#6537)

Signed-off-by: Sun Tan <sutan@redhat.com>
sunix added a commit that referenced this issue Nov 16, 2017
… using logstash-logback appenders (#6537)

Signed-off-by: Sun Tan <sutan@redhat.com>
dmytro-ndp pushed a commit that referenced this issue Dec 8, 2017
… using logstash-logback appenders (#6537)

Signed-off-by: Sun Tan <sutan@redhat.com>
@skabashnyuk
Copy link
Contributor

closing after discussion with @l0rd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

2 participants