Use different secrets for TLS and self-signed-cert #14176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
che-bot
added
status/code-review
|
@sleshchenko: PR check has been failed because it uses Jenkinsfile now, which has been merged in master tonight. So, it requires to take changes from master. |
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
sleshchenko
force-pushed
the
helmSelfSignedCert
branch
from
3025112
to
7c7128a
Compare
|
@dmytro-ndp Thanks for notifying me, rebased against master. |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
benoitf
approved these changes
Aug 12, 2019
|
removing |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It's like a best practice to generate CA certificate, propagate it to clients to configure their trust stores.
And generate another non-CA certificate based on CA for establishing https connection.
See https://wiki.mozilla.org/SecurityEngineering/x509Certs
https://gist.github.com/fntlnz/cf14feb5a46b2eda428e000157447309
So, this PR adds an ability to configure TLS cert for ingresses and CA cert for trust stores separately.
What issues does this PR fix or reference?
#14035
Release Notes
N/A
Docs PR
N/A