fix(helm): fix deploying che with helm installer when self-signed-cert is specified #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
requested review from
azatsarynnyy,
rhopp and
vparfonov
as code owners
…t is specified Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
sleshchenko
force-pushed
the
helmSelfSignedCert
branch
from
f3da7fe
to
28b33b1
Compare
sleshchenko
changed the title
|
I am +1 to include this in milestone |
|
@sleshchenko could you please fix compilation issue ? |
benoitf
approved these changes
Aug 12, 2019
…ned-cert is specified Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes deploying Che with helm installer when self-signed-cert is specified
What issues does this PR fix or reference?
It's related to eclipse-che/che#14035
It depends on eclipse-che/che#14176