Skip to content

Commit

Permalink
Use different secrets for TLS and self-signed-cert (#14176)
Browse files Browse the repository at this point in the history
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
  • Loading branch information
sleshchenko authored Aug 12, 2019
1 parent c31a25e commit f24796b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions deploy/kubernetes/helm/che/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ spec:
- name: CHE_SELF__SIGNED__CERT
valueFrom:
secretKeyRef:
key: tls.crt
name: {{ .Values.global.tls.secretName }}
key: ca.crt
name: {{ .Values.global.tls.selfSignedCertSecretName }}
optional: false
{{- end }}

Expand Down
3 changes: 2 additions & 1 deletion deploy/kubernetes/helm/che/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ global:
secretName: che-tls

## If self-signed certificate is enabled
## then certificate from `tls.secretName` will be propagated to Che components' trust stores
## then certificate from `tls.selfSignedCertSecretName` will be propagated to Che components' trust stores
useSelfSignedCerts: false
selfSignedCertSecretName: self-signed-cert

gitHubClientID: ""
gitHubClientSecret: ""
Expand Down

0 comments on commit f24796b

Please sign in to comment.