Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Github action with multi-CPU architecture support and multi docker file support #30

Merged
merged 8 commits into from
Aug 10, 2020

Conversation

skabashnyuk
Copy link
Contributor

  • Build and push to docker registry Dockerfile under linux/amd64,linux/s390x,linux/arm64,linux/ppc64le
  • Build and push to docker registry rhel.Dockerfile under linux/amd64
  • Allow to configure with secrets DOCKER_USERNAME, DOCKER_PASSWORD, DOCKER_IMAGE, DOCKER_REPO
  • Same workflow for master and prs
  • Is able to push tags

Results https://quay.io/repository/skabashn/che-jwtproxy?tab=tags
Synced code with che-incubator/configbump#5

@skabashnyuk
Copy link
Contributor Author

@benoitf
Copy link
Contributor

benoitf commented Jul 31, 2020

It is leaving rhel.Dockerfile untouched is it still working ?

@benoitf
Copy link
Contributor

benoitf commented Jul 31, 2020

should all cico scripts be disabled/removed as well ? it won't collide ?

Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Vendoring was evil anyway :)

@skabashnyuk
Copy link
Contributor Author

@benoitf

It is leaving rhel.Dockerfile untouched is it still working ?

Yes, I've checked. It works.

should all cico scripts be disabled/removed as well ?

Don't want to hurry up. Let's live it for some time.

it won't collide ?

Don't know. Need to talk with @mkuznyetsov @nickboldt

@nickboldt
Copy link
Contributor

nickboldt commented Aug 4, 2020

@skabashnyuk +0. I'm not going to comment on a PR that changes 417 files in a repo for which I'm neither an owner not an expert. If you want my input please make this into a set of several smaller, more manageable PRs.

That said... I don't see any changes to a rhel.Dockerfile similar to what you changed in Dockerfile, so this change might not be reflected in downstream. Is that intentional?

@skabashnyuk
Copy link
Contributor Author

@nickboldt it has 5 changed files and removed vendor folder are you sure you want me to split it?

@nickboldt
Copy link
Contributor

No, I'm OK with the deleted files since you explained the rationale in Slack. Upgrading my vote to +0.5

But I'm still wondering if you've forgotten to do anything in the rhel.Dockerfile file to match your changes in Dockerfile.

https://github.com/eclipse/che-jwtproxy/blob/a2fcdaedd8dfa4d660e23c5e7b17c07749d22acb/build/dockerfiles/rhel.Dockerfile

If you can explain why these changes are not applicable to downstream (as I suspect is the case), or add changes to the rhel.Dockerfile too, then I'll be +1.

@skabashnyuk
Copy link
Contributor Author

@skabashnyuk skabashnyuk merged commit 935b358 into eclipse-che:master Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants