Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Adding support for ppc64le on travis-ci #29

Closed
wants to merge 1 commit into from

Conversation

kumarvikas2020
Copy link
Contributor

@kumarvikas2020 kumarvikas2020 commented Jun 16, 2020

Signed-off-by: vikas kumar kumar.vikas@in.ibm.com

What does this PR do?

This PR will add support for ppc64le.

What issues does this PR fix or reference?

This PR is part of this initiative.

Signed-off-by: vikas kumar <kumar.vikas@in.ibm.com>
@sparkoo
Copy link
Member

sparkoo commented Jul 24, 2020

shouldn't we rather move to github actions?

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Jul 24, 2020

+1
I'll probably volunteer on that.

@kumarvikas2020
Copy link
Contributor Author

@sparkoo @skabashnyuk
Yes, github actions should be the preferable way, but unfortunately at present it does not support ppc64le architecture.

@sparkoo
Copy link
Member

sparkoo commented Jul 28, 2020

@sparkoo @skabashnyuk
Yes, github actions should be the preferable way, but unfortunately at present it does not support ppc64le architecture.

what about this https://github.com/uraimo/run-on-arch-action ? I didn't try it, but looks like there are ways how to do it.

@benoitf
Copy link
Contributor

benoitf commented Jul 28, 2020

buildx/docker supports ppc64le we are using it on other Che repositories

@benoitf
Copy link
Contributor

benoitf commented Jul 29, 2020

@kumarvikas2020
Copy link
Contributor Author

@benoitf I agree with this example. May be we should go by buildx way for the repositories that are building Docker images.
Repositories whose build outcomes are not Docker images, we can explore actions like https://github.com/uraimo/run-on-arch-action as suggested by @sparkoo

@benoitf
Copy link
Contributor

benoitf commented Jul 29, 2020

I would say that almost all our che repositories have docker images as result

@skabashnyuk
Copy link
Contributor

@kumarvikas2020 I was planning to migrate che-jwtproxy to something like che-incubator/configbump#5. Can you take a look if that will work for you too?

@ghatwala
Copy link
Contributor

ghatwala commented Aug 5, 2020

hi @kumarvikas2020 - agree on using github actions as output needed is docker image anyways. Can you try using PR changes #30 and attempt a build ?

@kumarvikas2020
Copy link
Contributor Author

@skabashnyuk @ghatwala
I tried building the images using the changes in #30.
The images are building correctly.

However, I have following observations:

  1. We are not creating multi-arch images from rhel.Dockerfile.

  2. In the Dockerfile, we need to copy passwd file from the builder image (as done in rhel.Dockerfile), otherwise we will get user related error.
    COPY --from=builder /etc/passwd /etc/passwd
    Error observed:
    docker: Error response from daemon: unable to find user appuser: no matching entries in passwd file.

@skabashnyuk
Copy link
Contributor

In the Dockerfile, we need to copy passwd file from the builder image (as done in rhel.Dockerfile), otherwise we will get user related error.

Will fix that

@kumarvikas2020
Copy link
Contributor Author

Closing this PR as ppc64le support has been enabled using GitHub Actions and Buildx.

@skabashnyuk
Copy link
Contributor

new images have been deployed https://quay.io/repository/eclipse/che-jwtproxy?tab=tags

@ghatwala
Copy link
Contributor

ghatwala commented Aug 10, 2020

hey @skabashnyuk thanks for making this image as "multi-arch" , is there a plan to follow suit for others here too - https://quay.io/organization/eclipse ? ( wherever applicable )

@skabashnyuk
Copy link
Contributor

hey @skabashnyuk thanks for making this image as "multi-arch" , is there a plan to follow suit for others here too - https://quay.io/organization/eclipse ? ( wherever applicable )

hard to tell.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants